Fix formatting of relative paths

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.4 (unreleased)
+
+* Print absolute filepaths as relative again (as with 2.1 and before) if they
+  are below the current directory. (The-Compiler, #246)
+
 # 2.3 (2021-01-16)
 
 * Add [pre-commit](https://pre-commit.com) hook (Clément Robert, #244).

tests/test_utils.py

@@ -1,8 +1,45 @@
 import ast
+import os
+import pathlib
+
+import pytest
 
 from vulture import utils
 
 
+class TestFormatPath:
+    @pytest.fixture
+    def tmp_cwd(self, tmp_path, monkeypatch):
+        cwd = tmp_path / "workingdir"
+        cwd.mkdir()
+        monkeypatch.chdir(cwd)
+        return cwd
+
+    def test_relative_inside(self):
+        filepath = pathlib.Path("testfile.py")
+        formatted = utils.format_path(filepath)
+        assert formatted == filepath
+        assert not formatted.is_absolute()
+
+    def test_relative_outside(self, tmp_cwd):
+        filepath = pathlib.Path(os.pardir) / "testfile.py"
+        formatted = utils.format_path(filepath)
+        assert formatted == filepath
+        assert not formatted.is_absolute()
+
+    def test_absolute_inside(self, tmp_cwd):
+        filepath = tmp_cwd / "testfile.py"
+        formatted = utils.format_path(filepath)
+        assert formatted == pathlib.Path("testfile.py")
+        assert not formatted.is_absolute()
+
+    def test_absolute_outside(self, tmp_cwd):
+        filepath = (tmp_cwd / os.pardir / "testfile.py").resolve()
+        formatted = utils.format_path(filepath)
+        assert formatted == filepath
+        assert formatted.is_absolute()
+
+
 def check_decorator_names(code, expected_names):
     decorator_names = []
 

vulture/utils.py

@@ -1,5 +1,5 @@
 import ast
-import os
+import pathlib
 import sys
 import tokenize
 
@@ -47,7 +47,7 @@ def condition_is_always_true(condition):
 
 def format_path(path):
     try:
-        return path.relative_to(os.curdir)
+        return path.relative_to(pathlib.Path.cwd())
     except ValueError:
         # Path is not below the current directory.
         return path