Fix formatting of relative paths #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 17 17
Lines 631 631
=======================================
Hits 627 627
Misses 4 4
Continue to review full report at Codecov.
|
Prior to vulture 2.2, it was possible to pass an absolute path below the current directory, and the report showed a relative path instead:
With vulture 2.1, inside `~/proj/qutebrowser/git/`:
$ vulture ~/proj/qutebrowser/git/qutebrowser/qutebrowser.py
qutebrowser/qutebrowser.py:138: unused function 'directory' (60% confidence)
qutebrowser/qutebrowser.py:186: unused function 'main' (60% confidence)
With vulture 2.3:
$ vulture ~/proj/qutebrowser/git/qutebrowser/qutebrowser.py
/home/florian/proj/qutebrowser/git/qutebrowser/qutebrowser.py:138: unused function 'directory' (60% confidence)
/home/florian/proj/qutebrowser/git/qutebrowser/qutebrowser.py:186: unused function 'main' (60% confidence)
This is due to #226, notably the `path.relative_to(os.curdir)` in `utils.format_path` - this won't work properly if the input is absolute:
>>> import os, pathlib
>>> os.getcwd()
'/tmp'
>>> pathlib.Path('/tmp/somefile').relative_to('.')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.9/pathlib.py", line 928, in relative_to
raise ValueError("{!r} is not in the subpath of {!r}"
ValueError: '/tmp/somefile' is not in the subpath of '' OR one path is relative and the other is absolute.
>>> pathlib.Path('/tmp/somefile').relative_to(pathlib.Path.cwd())
PosixPath('somefile')
|
Ah, it looks like vulture turns relative paths absolute internally, so this is even an issue if passed a relative path: $ vulture qutebrowser/qutebrowser.py
/home/florian/proj/qutebrowser/git/qutebrowser/qutebrowser.py:138: unused function 'directory' (60% confidence)
/home/florian/proj/qutebrowser/git/qutebrowser/qutebrowser.py:186: unused function 'main' (60% confidence) |
The-Compiler
added a commit
to qutebrowser/qutebrowser
that referenced
this pull request
Jan 19, 2021
|
Good catch. Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to vulture 2.2, it was possible to pass an absolute path below the current directory, and the report showed a relative path instead:
With vulture 2.1, inside
~/proj/qutebrowser/git/:With vulture 2.3:
This is due to #226, notably the
path.relative_to(os.curdir)inutils.format_path- this won't work properly if the input is absolute:Checklist:
cc @ju-sh