-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metadata dialog backdrop click to exit #6421
Fix metadata dialog backdrop click to exit #6421
Conversation
Cloudflare Pages deployment
|
cac64ac
to
a553ef5
Compare
|
When a dialog contains forms it should require an explicit close button to be pressed or an additional dialog that shows to confirm with the user that any changes made to the form will not be saved. It is extremely easy to close a dialog using a click on the scrim by accident. |
I'm not sure how I feel about a confirmation dialog when trying to click out through the backdrop. Ideally, it should only show up when there are unsaved changes in the form but that's beyond this bugfix PR (clicking in dialog and releasing the mouse outside it causing it to close). I also think that disabling the click for some dialogs while others not is inconsistent and annoying to the user. I'm not sure how common it is to accidentally click outside, but with this PR it should be a bit harder to do so. |
I think we massively overuse modals, and I hate it, but this makes the modal function the same as all the others while fixing the original bug. |
Fix metadata dialog backdrop click to exit Original-merge: e1deddc Merged-by: thornbill <[email protected]> Backported-by: thornbill <[email protected]>
Changes
Issues
Fixes #5723