-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to exit from fullscreen with the back button in ExoPlayer #1173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable. Thanks for the contribution!
Im not sure if this was the change but now when i use back gesture it goes to portrait mode from landscape mode instead of actually leaving fullscreen @Maxr1998 |
Yes, that's how it's supposed to work. You switch from landscape to portrait and leave fullscreen at the same time. It's the same that happens when pressing the fullscreen switcher in the UI. |
i dont mean to be offensive, but this is pretty useless behavior forcing you to take 2 actions if you want to close the player, no matter what. its actually horrible cause after leaving landscape you have to move your finger to a different edge to be able to back gesture. i dont see how it could ever be useful, if i want to close the player i want to do just that. if i want extra options/info i will tap the screen. its pretty standard behavior on every app and player that ive used. at least give an option to disable it or have it disabled when "start landscape mode" is enabled. i dont think i can emphasize enough how much of a pain it is to have to gesture back twice every time i need to close the player, it doesnt even pause it. if i wanted to go to portrait mode i would press "exit full screen" icon that is there for a reason. |
Is there an option to disable this? Can one be added? I expect the bottom back button to do the same thing as the back button at the top but it doesn't. |
There is no option thats the most annoying part of all, i genuinely think you have to be masochist to enjoy this feature in any way |
Please open an issue so we can discuss this change. If there is a high demand for a revert/preference we may consider it. |
@nielsvanvelzen as suggested, please see #1256 |
When using ExoPlayer, this allows users to exit the full-screen mode by pressing the back button, similar to e.g. the YouTube app.