Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable exit from full screen using the back button #1256

Open
mdinger opened this issue Dec 15, 2023 · 11 comments
Open

Add an option to disable exit from full screen using the back button #1256

mdinger opened this issue Dec 15, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@mdinger
Copy link

mdinger commented Dec 15, 2023

Add an option to disable the feature exit from full screen with the back button

This feature was merged in #1173 for version 2.6.0. I propose an option be added to allow back to close the player or switch to portrait mode per a users preference (I suspect the toggle could go in client settings).

Some users may strongly dislike the back button feature and such an option should please them.

@sunnyd24
Copy link

I would second having an option to control the back button behaviour, if I have understood this issue correctly.

I am struggling to close from fullscreen exoplayer in landscape quickly using the android back button (I'm sure I didn't have this issue previously). Unfortunately, this coincided with an update to OneUI 6.0 on Samsung S21 Ultra, so I thought that Android 14 broke this, but most likely not.

The current implementation in v2.6.0 requires the use the soft button only to exit from fullscreen video. This soft back button is found on the top left of screen, which is difficult to reach when using your right hand to hold phone.

The android back button just keep switching between fullscreen landscape mode and portrait mode, but keeps video playing, overall this isn't a nice UI friendly implementation.

@mdinger
Copy link
Author

mdinger commented Jan 11, 2024

Yes that is the purpose of this bug.

There already is a button to switch from full screen to portrait and back so I don't quite understand the justification for stealing the most important button to suite a niche use case (when there already is a button to do so). I would argue this breaks the standard expectation of the user because the back button is supposed to go back and here it does something entirely unrelated.

The principal of least astonishment seems to be a standard concept in good user interface design and so I'd think there should be strong justification for violating it (the justification from the #1173 seems to be that another app does this so we should too).

@Des-m0nd
Copy link

Des-m0nd commented Jan 31, 2024

Yes I fully agree with the suggestion, I too, would like to be able to disable this, it is just so unintuitive for back button to be changing the landscape/portrait mode. Shouldn't this be done via a separate UI button instead?

@kyrdkyrskyr
Copy link

I also agree this should be reverted or optional.

My tablet is always in landscape mode so it rotating to portrait is ridiculous. Tapping back should go back to the previous screen, not rotate the device to an orientation that it was never in.
In the same vein, the dedicated button for leaving full screen should not be rotating to portrait either!

@noahrama
Copy link

noahrama commented Aug 1, 2024

Additionally, swiping back requires me to swipe in the upper portion of the screen, which is different behaviour from other android apps - I can swipe anywhere with those

@Des-m0nd
Copy link

Des-m0nd commented Oct 6, 2024

Hate that this is still not a feature, after so many months I am still not able to get used to not being able to simply "Back" to close the video...

@sunnyd24
Copy link

sunnyd24 commented Oct 6, 2024 via email

@Des-m0nd
Copy link

Des-m0nd commented Oct 6, 2024

I agree, I'm still waiting too....... I still try pressing back through habit and it just rotates the video on screen. That's not the correct function of the back button! Suggest using Findroid, this has the back button implemented correctly!

On Sun, 6 Oct 2024, 7:25 pm Des-m0nd, @.> wrote: Hate that this is still not a feature, after so many months I am still not able to get used to not being able to simply "Back" to close the video... — Reply to this email directly, view it on GitHub <#1256 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDYCAVDMXD4LP7LU7QVJCTZ2F57ZAVCNFSM6AAAAABAWEOS3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGUZTIOJSHA . You are receiving this because you commented.Message ID: @.>

Thank you for suggesting! Didn't know there is an alternative for jellyfin. Seems intuitive so far, any downsides for using Findroid?

@noahrama
Copy link

noahrama commented Oct 7, 2024

breaking android design guidelines is bad

@Chestnut7
Copy link

Also waiting for this "feature" to be fixed to be in line with standard expected Android back button behaviour. It's very annoying and spoils an otherwise great experience.

@l3s2d
Copy link

l3s2d commented Dec 28, 2024

Just to reiterate the issues with the current behavior:

  • Deviates from the behavior in apps like Netflix and Disney+, where the back button/gesture stops video playback and returns to the video info screen
  • After using the back button/gesture once, using it again goes back to fullscreen, which not even Hulu and YouTube do
  • On a tablet in landscape mode forces the app into a half-screen vertical view

Please add an option to disable this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants