Expose site source #107
Expose site source #107
Conversation
spec/webmock/api_get_repo_pages.json
Outdated
| {"message":"Not Found","documentation_url":"https://developer.github.com/v3"} |
There was a problem hiding this comment.
Hm this should have valid data :(
There was a problem hiding this comment.
I didn't modify this. Restored the whitespace via 43e425b to clean up the diff.
Based on trying to implement things differently the first time, I believe this is here to ensure that repo compat is exercised for the integration test.
There was a problem hiding this comment.
Ah! Ok cool, looking through the history, it looks like it's trying to fetch data from this repo, which doesn't have Pages enabled so that'd explain it. Womp. Ideally we'd exercise both repo compat and the repo API stuff.
There was a problem hiding this comment.
Missed this at first glance. Added unit tests via 7abdfe2.
|
I love this!! |
There was a problem hiding this comment.
I am suuuuuper stoked for this!
One enhancement we might consider is adding a Liquid tag like {%- github_edit_link page -%} which would output an HTML <a> link all built for you. The big reason not to do that is people will want lots of options like setting CSS tags and so forth. Maybe {%- github_edit_url page -%}? 😄 Something to think about.
Thank you!!
|
@jekyllbot: merge +minor. |
...and one more PR to follow up on expose repo license and expose repo visibility.
The idea is still to enable a template as follows:
{% if site.github.private != true and site.github.license %} <div class="footer border-top border-gray-light mt-5 text-right"> This site is open source. <a href="{{ site.github.repository_url }}/edit/{{ site.github.source.branch }}{{ site.github.source.path }}{{ page.path }}">Help improve this page</a> </div> {% endif %}