Expose repo license #106
Merged
Expose repo license #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
requested changes
Aug 9, 2017
| # If not specified, defaults to the hash key | ||
| # | ||
| # Returns a symbol representing the instance method | ||
| def self.def_hash_delegator(hash, key, method = nil) |
There was a problem hiding this comment.
The order of these is hard to read. I think this is easier to read:
def self.def_hash_delegator(method, hash, key)
Having the method name only some of the times is hard to grok.
I guess matching it with def_delegator is a noble goal. In that case, I'd say we should always require the method argument. Also, for 👀 sake, maybe align each argument in a table-like format for easy scanning?
There was a problem hiding this comment.
Good call. Implemented via 211fe3d.
parkr
approved these changes
Aug 12, 2017
|
@jekyllbot: merge +minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #105, this PR exposes the repository's licenses as
site.github.license. I'd like to use this to conditionally expose an "This site is open source, help improve this page" link if a repo is public and has an open source license (versus public but not necessarily looking for contributions).In doing this, I realized that we had a handful of very similar methods on the Repository model that simply delegated to a hash. Forwardable can't delegate to
[], only to the method itself, so I created a quickdef_hash_delegatorhelper, to allow us to DRY things up a bit and delegate a method more easily to a hash key. It works exactly likedef_delegator, e.g.def_hash_delegator :repo_info, :licenseis the same as:and
def_hash_delegator :repo_info, :description, :taglineis the same as: