Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::is space not found by MSVC #621

Closed
ithron opened this issue Sep 4, 2018 · 2 comments
Closed

std::is space not found by MSVC #621

ithron opened this issue Sep 4, 2018 · 2 comments

Comments

@ithron
Copy link
Contributor

ithron commented Sep 4, 2018

In binary.cpp lines 68 MSVC complains:

error C2039: 'isspace': is not a member of 'std'

This is of course correct, since std::isspace is defined in <cctype> not in <ctype.h>
ithron pushed a commit to ithron/yaml-cpp that referenced this issue Sep 4, 2018
Fix include for std::isspace, fixes jbeder#621
e701965
@ithron ithron mentioned this issue Sep 4, 2018
Merged
@jbeder jbeder closed this as completed in d0da144 Sep 4, 2018
@jbeder
Copy link
Owner

jbeder commented Sep 4, 2018

Thanks!

@ghost ghost mentioned this issue Sep 2, 2020
Closed
@1062435254
Copy link

good job

@wolfv wolfv mentioned this issue Sep 18, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ithron @jbeder @1062435254