Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is get error on windows: util/common.h(26): error C2039: 'isspace': is not a member of 'std' #31

Closed
ghost opened this issue Sep 2, 2020 · 3 comments
Labels
bug - compilation error Something isn't working cross-platform issue - windows Help wanted - Good for contributing if you are on windows

Comments

@ghost
Copy link

ghost commented Sep 2, 2020

Compile using VC 17 / 19 and Camke.
See same here: jbeder/yaml-cpp#621

@alandefreitas
Copy link
Owner

Can you check if this can be fixed by including <cctype> and removing std:: on that file?

@alandefreitas alandefreitas added bug - compilation error Something isn't working cross-platform issue - windows Help wanted - Good for contributing if you are on windows labels Sep 2, 2020
@ghost
Copy link
Author

ghost commented Sep 3, 2020

I make change you suggest. You wanted compeltly remove all occurrence of std::? I did not compile anymore.

image

@alandefreitas
Copy link
Owner

No no. Only from std::isspace to isspace, as in jbeder/yaml-cpp#621.

Anyway, this commit might have solved your issue:
e67a7d6

If it hasn't, try changing the std::ispace to isspace in lines 27 and 33 of common.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug - compilation error Something isn't working cross-platform issue - windows Help wanted - Good for contributing if you are on windows
Projects
None yet
Development

No branches or pull requests

1 participant