Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom pagination item capability #591

Merged
merged 5 commits into from
Nov 21, 2020
Merged

Custom pagination item capability #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42d517d
Custom pagination item capability
dbrw Apr 12, 2018
fcd9e19
Custom pagination item capability
dbrw Apr 12, 2018
f04a4ea
Merge branch 'patch-1' of https://github.com/dbrw/list.js into patch-1
Dec 18, 2018
bcd29ac
adding tests for custom pagination item
Dec 18, 2018
ecd6eae
Merge branch 'master' into patch-1
javve Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 103 additions & 3 deletions __test__/pagination.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ describe('Pagination', function () {
expect($(pagination.find('li').get(4)).hasClass('active')).toEqual(true)
expect($(pagination.find('li').get(5)).hasClass('active')).toEqual(false)
})

it('should show last page with show(17,2)', function () {
list.show(17, 2)
expect(pagination.find('a').length).toEqual(5)
Expand All @@ -267,5 +266,106 @@ describe('Pagination', function () {
expect($(pagination.find('li').get(3)).hasClass('active')).toEqual(false)
expect($(pagination.find('li').get(4)).hasClass('active')).toEqual(true)
})
})
})
});

describe('Custom settings, pagination: { item: "<button><span class=page></span></button>" }', function() {
var list,
itemHTML,
pagination;

beforeAll(function() {
itemHTML = fixturePagination.list(['name'])
list = new List('list-pagination', {
valueNames: ['name'],
item: itemHTML,
page: 2,
pagination: {
item: "<button><span class=page></span></button>",
},
}, fixturePagination.all);

pagination = $('.pagination');
});

afterAll(function() {
fixturePagination.removeList();
});

it('should have default settings', function() {
expect(pagination.find('span').length).toEqual(4);
expect(pagination.find('span').get(0).innerHTML).toEqual("1");
expect(pagination.find('span').get(1).innerHTML).toEqual("2");
expect(pagination.find('span').get(2).innerHTML).toEqual("3");
expect(pagination.find('span').get(3).innerHTML).toEqual("...");
expect(pagination.find('span').get(4)).toEqual(undefined);
});

it('should show same pages for show(7,2) and show(8,2)', function() {
list.show(7, 2);
expect(pagination.find('span').length).toEqual(7);
expect(pagination.find('span').get(0).innerHTML).toEqual("...");
expect(pagination.find('span').get(1).innerHTML).toEqual("2");
expect(pagination.find('span').get(2).innerHTML).toEqual("3");
expect(pagination.find('span').get(3).innerHTML).toEqual("4");
expect(pagination.find('span').get(4).innerHTML).toEqual("5");
expect(pagination.find('span').get(5).innerHTML).toEqual("6");
expect(pagination.find('span').get(6).innerHTML).toEqual("...");
expect(pagination.find('span').get(7)).toEqual(undefined);
expect($(pagination.find('button').get(2)).hasClass('active')).toEqual(false);
expect($(pagination.find('button').get(3)).hasClass('active')).toEqual(true);
expect($(pagination.find('button').get(4)).hasClass('active')).toEqual(false);
});

it('should show same pages for show(7,2) and show(8,2)', function() {
list.show(8, 2);
expect(pagination.find('span').length).toEqual(7);
expect(pagination.find('span').get(0).innerHTML).toEqual("...");
expect(pagination.find('span').get(1).innerHTML).toEqual("2");
expect(pagination.find('span').get(2).innerHTML).toEqual("3");
expect(pagination.find('span').get(3).innerHTML).toEqual("4");
expect(pagination.find('span').get(4).innerHTML).toEqual("5");
expect(pagination.find('span').get(5).innerHTML).toEqual("6");
expect(pagination.find('span').get(6).innerHTML).toEqual("...");
expect(pagination.find('span').get(7)).toEqual(undefined);
expect($(pagination.find('button').get(2)).hasClass('active')).toEqual(false);
expect($(pagination.find('button').get(3)).hasClass('active')).toEqual(true);
expect($(pagination.find('button').get(4)).hasClass('active')).toEqual(false);
});

it('should test show(14,2)', function() {
list.show(14, 2);
expect(pagination.find('span').length).toEqual(6);
expect(pagination.find('span').get(0).innerHTML).toEqual("...");
expect(pagination.find('span').get(1).innerHTML).toEqual("5");
expect(pagination.find('span').get(2).innerHTML).toEqual("6");
expect(pagination.find('span').get(3).innerHTML).toEqual("7");
expect(pagination.find('span').get(4).innerHTML).toEqual("8");
expect(pagination.find('span').get(5).innerHTML).toEqual("9");
expect(pagination.find('span').get(6)).toEqual(undefined);
expect($(pagination.find('button').get(2)).hasClass('active')).toEqual(false);
expect($(pagination.find('button').get(3)).hasClass('active')).toEqual(true);
expect($(pagination.find('button').get(4)).hasClass('active')).toEqual(false);
});

it('should show last page with show(17,2)', function() {
list.show(17, 2);
expect(pagination.find('span').length).toEqual(4);
expect(pagination.find('span').get(0).innerHTML).toEqual("...");
expect(pagination.find('span').get(1).innerHTML).toEqual("7");
expect(pagination.find('span').get(2).innerHTML).toEqual("8");
expect(pagination.find('span').get(3).innerHTML).toEqual("9");
expect(pagination.find('span').get(4)).toEqual(undefined);
expect($(pagination.find('button').get(1)).hasClass('active')).toEqual(false);
expect($(pagination.find('button').get(2)).hasClass('active')).toEqual(false);
expect($(pagination.find('button').get(3)).hasClass('active')).toEqual(true);
});

it('should handle page = 0', function() {
expect(list.listContainer.style.display).toBe('');
list.show(0, 0);
expect(list.listContainer.style.display).toBe('none');
list.show(1, 1);
expect(list.listContainer.style.display).toBe('block');
});
});
});
2 changes: 1 addition & 1 deletion src/pagination.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ module.exports = function (list) {
return function (options) {
var pagingList = new List(list.listContainer.id, {
listClass: options.paginationClass || 'pagination',
item: "<li><a class='page' href='#'></a></li>",
item: options.item || "<li><a class='page' href='#'></a></li>",
valueNames: ['page', 'dotted'],
searchClass: 'pagination-search-that-is-not-supposed-to-exist',
sortClass: 'pagination-sort-that-is-not-supposed-to-exist',
Expand Down