Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom pagination item capability #591

Merged
merged 5 commits into from
Nov 21, 2020
Merged

Custom pagination item capability #591

merged 5 commits into from
Nov 21, 2020

Conversation

dbrw
Copy link
Contributor

@dbrw dbrw commented Apr 12, 2018

You can add pagination custom item with this PR.

You can add pagination custom item with this PR.
@Jastrzebowski
Copy link

I've just needed it too and thought before writing code lets check if there are no PRs waiting ;) Would love to see it soon. Will solve usage with Bootstrap 4

@javve
Copy link
Owner

javve commented Dec 16, 2018

Sorry about the super slow reply! this looks like a great feature. ⭐️
However, I would love to have a test included in this PR as well to make sure that it works.

@dbrw
Copy link
Contributor Author

dbrw commented Dec 18, 2018

More commits will follow.

@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #591 (ecd6eae) into develop (35aa35f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #591   +/-   ##
========================================
  Coverage    94.56%   94.57%           
========================================
  Files           19       19           
  Lines          810      811    +1     
  Branches       188      189    +1     
========================================
+ Hits           766      767    +1     
  Misses          31       31           
  Partials        13       13           
Impacted Files Coverage Δ
src/pagination.js 92.30% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35aa35f...ecd6eae. Read the comment docs.

@javve javve changed the base branch from master to develop November 21, 2020 20:59
@javve
Copy link
Owner

javve commented Nov 21, 2020

This is great! Thank you so much.

...and, heh, sorry about the suuuuper slow review and merge 😳

@javve javve merged commit 3517ece into javve:develop Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants