feat: allow user to move jan folder #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namchuai
force-pushed
the
feat/allow-user-move-jan-folder
branch
7 times, most recently
from
1f04ca4 to
73a52d3
Compare
Signed-off-by: James <[email protected]> chore: add get app path api to access from node module update api name and handle some cases when syncing files Signed-off-by: James <[email protected]> remove redundant API Signed-off-by: James <[email protected]> add current path Signed-off-by: James <[email protected]>
louis-menlo
force-pushed
the
feat/allow-user-move-jan-folder
branch
from
a86b243 to
0610408
Compare
louis-menlo
force-pushed
the
feat/allow-user-move-jan-folder
branch
5 times, most recently
from
5425521 to
fbfd924
Compare
louis-menlo
force-pushed
the
feat/allow-user-move-jan-folder
branch
from
fbfd924 to
2f9cb2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Users can change default Jan app data location, give users control over how their own fs is used.
Flow:
Notice:
This is an experimental feature, users now have to enable Experimental Toggle from settings to access this feature until #1618 is implemented.
Docs will be updated after #1618 is implemented
Fixes Issues
Screenshots
Self Checklist