Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show a proper error message on download failure #1345

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

Its currently only show a generic message such as Download Cancelled or nothing showing up.

Fixes Issues

fixes #1193

Screenshots

Note: I hacked my hosts configuration so the message is a bit unclear

Screenshot 2024-01-04 at 20 06 29

@github-actions github-actions bot added the type: bug Something isn't working label Jan 4, 2024
@hiento09 hiento09 merged commit d0edcbb into main Jan 4, 2024
7 checks passed
@hiento09 hiento09 deleted the fix/distinguish-cancel-and-download-error-message branch January 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: Hub Download Model should show error message when HuggingFace CDN is down
3 participants