Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Hub Download Model should show error message when HuggingFace CDN is down #1193

Closed
dan-menlo opened this issue Dec 25, 2023 · 0 comments · Fixed by #1345
Closed

bug: Hub Download Model should show error message when HuggingFace CDN is down #1193

dan-menlo opened this issue Dec 25, 2023 · 0 comments · Fixed by #1345
Assignees
@louis-menlo
Labels
type: bug Something isn't working

Comments

@dan-menlo
Copy link
Contributor

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  1. Go to Hub
  2. Download Phi-2-3b or Mixtral
  3. Sometimes, the CDN for Huggingface will error out in the console
  4. User sees a confusing state, where the Download keeps stopping for no reason

image

We likely need to show the correct error message to the user if the HuggingFace CDN is not down/not working.

Long-term we should probably provide a mirror or alternative file download to HuggingFace.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

hub-download-error

Desktop (please complete the following information):

  • OS: Mac OSX, 16gb RAM
  • Version 0.4.3
@dan-menlo dan-menlo added the type: bug Something isn't working label Dec 25, 2023
@freelerobot freelerobot moved this to Planned in Menlo Dec 26, 2023
@urmauur urmauur moved this from Planned to In Progress in Menlo Dec 28, 2023
@urmauur urmauur assigned louis-menlo and unassigned urmauur Dec 28, 2023
@louis-menlo louis-menlo moved this from In Progress to Planned in Menlo Dec 29, 2023
@louis-menlo louis-menlo moved this from Planned to In Progress in Menlo Jan 2, 2024
@louis-menlo louis-menlo mentioned this issue Jan 4, 2024
Merged
@louis-menlo louis-menlo moved this from In Progress to In Review in Menlo Jan 4, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Menlo Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-menlo louis-menlo

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show a proper error message on download failure janhq/jan
3 participants
@urmauur @dan-menlo @louis-menlo