-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: let users change default installation directory janroot
#1010
Comments
janroot
janroot
janroot
janroot
janroot
Todo
1. Allow users to choose the default folder configurable on installationFor @louis-jan @namchuai to configure 2. Allow users to change the model folder directoryFull design flow: https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=2052-155715&mode=design&t=ZWZGgzJWErWbLVBs-4 Preview: Error when the folder is not available:Side note3. Allow users to change the installation directorySimilarly for changing app directory |
I noticed we're also letting users change model directory, in addition to Questions:
My concern is the designs introduce engineering scope creep, that (1) doesn't solve user problems and (2) prone to bugs |
Edge cases:
|
This is my main concern with increasing the scope of this ticket to let users fork off ~/models. This means mac users will be left with many orphaned Let's do one thing at a time. Reduce complexity please. |
janroot
janroot
To doAllow users to change the app directory in settings DesignFull design flow: https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=2270-285004&mode=design&t=e4y3O3QchhS4m1GT-4 Preview |
Archive @0xSage's original comment: Problem Success Criteria
Not in scope
Additional context |
Goal
Allow users to change the app data folder in settings
Design
Full design flow: https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=2270-285004&mode=design&t=bQyiFG80Dcr1XlBm-4
User flow
Settings / Advanced Settings
Jan Data Folder
Error scenarios
The text was updated successfully, but these errors were encountered: