Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the tck-audit profile by default so that the org.jboss.test-a… #388

Merged
merged 4 commits into from
Jun 21, 2022
Merged

Disable the tck-audit profile by default so that the org.jboss.test-a… #388

merged 4 commits into from
Jun 21, 2022

Conversation

starksm64
Copy link
Contributor

@starksm64 starksm64 commented Jun 20, 2022

…udit dependencies are not seen by default in the TCK test artifact dependencies.

The build needs -DtckAuditSourceGen to work with this change

Signed-off-by: Scott M Stark [email protected]

…udit dependencies are not seen by default in the TCK test artifact dependencies.

The build needs -DgenerateSource to run with this change

Signed-off-by: Scott M Stark <[email protected]>
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped some minor comments.

Use tckAuditSourceGen for activation property and document why the profile is not active by default

Signed-off-by: Scott M Stark <[email protected]>
@starksm64 starksm64 merged commit 22d9a76 into jakartaee:master Jun 21, 2022
manovotn added a commit to manovotn/cdi-tck that referenced this pull request Jul 11, 2022
manovotn added a commit that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants