-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.0.5 fails on a missing dependency #383
Comments
Yea, I think this one is not synced with Central. I am not sure if any other project still uses this, I recall updating it for the sake of EE 9 but we should probably look into what it actually does for this projects (it was a test coverage tool IIRC and probably required update of the TCK audit files as well?) and move it as a submodule here. |
BTW this is not just 4.0.5, this should be true for any CDI TCK version. |
The test-audit dependency is only used during the build of the TCK dist. It can be disable in one of two ways:
The tck-audit profile is enabled by default because you cannot build the TCK without it enabled. We could disable it by default and have to enable it during builds. The other thing I have been meaning to look into is to generate a separate release pom for the TCK artifacts that do not include these build related profiles. |
This should now be resolved via #388 |
Going forward, starting when there is a 4.0.6 release, we won't be leaking test-audit dependency that is only need for building the TCK to the released test artifacts. |
Coming back to this, I don't think this was a good decision. Not being able to build the project without a switch smells like bad practice. I'd rather people excluded the dependency if it is a problem. |
My understanding is that you can build the project without an extra cmdline argument, it just won't generate the audit protocols? |
@Ladicek that was my understanding as well (and shame on me for not trying it out) but that's not the case. |
Ouch! Yea I didn't try it either :-) OK, that's bad. Frankly, I don't understand why we don't publish |
I agree. |
Yes, the latest workaround the jboss repo 503 errors was focused on the runtime side of usage, not the build side. There still is the issue of having dependencies in the tck artifacts that are not used. The tck-audit*.xml files and annotations generation should probably be in a separate project that is consumed by the tck test artifacts. There is no reason to build these every time the tests are built. |
I am not sure I know what are you talking about? This
There was always the option to do
True, a lot of bigger projects import dependencies with exlusions to avoid this. However, a project that imports TCKs is likely a projects that's meant to test run it in which case I don't see any big harm in just having it there. Unless I am missing something. |
One could use -DskipTckAudit, but every downstream consumer who was running into 503 errors had to do that. Since we build the tck artifacts, I switched the burden of avoiding the jboss repo errors to the build step in the eclipse ci environment so that every downstream user did not have to deal with the problem. It was projects that were importing the TCKs to run them that were seeing the unused test-audit-impl dependency causing errors when the tck-audit profile was enabled by default. |
I understand, but if we manage to get the |
Correct, but there still is the issue of building the spec annotations every time, for both the impl and web tck artifacts. |
@starksm64 @dstepanov got an update from the JIRA I created, the With that, the TCK build should no longer be an issue even in the default setup. Therefore, I'll revert changes in #388 |
It looks like
org.jboss.test-audit:jboss-test-audit-impl
is not available in the maven central:It is available in the Jboss repo but it would be nice not to require the use of a custom repo.
The text was updated successfully, but these errors were encountered: