Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build hotRod image similar to all-in-one #5745

Closed
wants to merge 3 commits into from
Closed

Build hotRod image similar to all-in-one #5745

wants to merge 3 commits into from

Conversation

Manoramsharma
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Similar to the functionality we have for all-in-one image I tried to achieve same build configuration supported by corresponding script file.

Checklist

@Manoramsharma Manoramsharma requested a review from a team as a code owner July 14, 2024 22:00
yurishkuro
yurishkuro reviewed Jul 16, 2024
View reviewed changes
.github/workflows/ci-hotrod.yml Outdated Show resolved Hide resolved
scripts/hotrod-integration-test.sh Outdated Show resolved Hide resolved
scripts/hotrod-integration-test.sh Outdated Show resolved Hide resolved
scripts/hotrod-integration-test.sh Show resolved Hide resolved
@Manoramsharma
Done with the required changes
d8bdafd 
Signed-off-by: Manoramsharma <[email protected]>
@Manoramsharma Manoramsharma requested a review from yurishkuro July 17, 2024 17:32
@yurishkuro
Copy link
Member

please rebase

yurishkuro
yurishkuro reviewed Jul 18, 2024
View reviewed changes
scripts/hotrod-integration-test.sh
run_integration_test() {
local image_name="$1"
export CID
CID=$(docker run -d --name "${BINARY}" -p 8080:8080 "${image_name}:${GITHUB_SHA}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have a bad merge, this is not how we run integration tests how.

@yurishkuro yurishkuro mentioned this pull request Jul 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro left review comments

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip building HotROD for all platforms for pull requests
2 participants
@Manoramsharma @yurishkuro