Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip building HotROD for all platforms for pull requests #5743

Closed
yurishkuro opened this issue Jul 14, 2024 · 2 comments · Fixed by #5765
Closed

Skip building HotROD for all platforms for pull requests #5743

yurishkuro opened this issue Jul 14, 2024 · 2 comments · Fixed by #5765
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

To speed up CI for pull requests we avoid expensive multi-platform image building. For example, the all-on-one CI workflow .github/workflows/ci-all-in-one-build.yml uses BUILD_FLAGS=-l -D -p linux/amd64:

  • -l for local build only (no pushing to public registry)
  • '-D' to skip building debug image
  • '-p' to only build for the GH runner's platform

We should reproduce the same functionality for .github/workflows/ci-hotrod.yml and scripts/hotrod-integration-test.sh
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Jul 14, 2024
@Manoramsharma
Copy link
Contributor

Hi @yurishkuro, as per my understanding do we have to achieve the similar BUILD_FLAGS configuration while building the image for HotROD if running on a Pull request. And defining those flags action to the corresponding script file?

I can come up with a PR if you can guide me more about the issue and if I am thinking in a right direction?

@yurishkuro
Copy link
Member Author

yes, we can replicate similar setup and CLI flags from the other scripts

@Manoramsharma Manoramsharma mentioned this issue Jul 14, 2024
Closed
4 tasks
@Charan-Sharan Charan-Sharan mentioned this issue Jul 18, 2024
Closed
4 tasks
@Manoramsharma Manoramsharma mentioned this issue Jul 19, 2024
Merged
4 tasks
FlamingSaint pushed a commit to FlamingSaint/jaeger that referenced this issue Jul 20, 2024
@Manoramsharma @yurishkuro @FlamingSaint
Skip building HotROD for all platforms for pull requests (jaegertraci…
32a5153 
…ng#5765)

## Which problem is this PR solving?
- Resolves jaegertracing#5743 

## Description of the changes
- Similar to the functionality we have for all-in-one image I tried to
achieve same build configuration supported by corresponding script file.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Manoramsharma <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
2 participants
@yurishkuro @Manoramsharma