Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase codecov of pkg/kafka #5682

Merged
merged 37 commits into from
Jul 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
7bb8259
added more options auth for cassandra
hellspawn679 Jun 14, 2024
e8775e7
added AllowedAuthenticators
hellspawn679 Jun 14, 2024
89b2275
Merge branch 'jaegertracing:main' into auth
hellspawn679 Jun 16, 2024
9346d16
added aiven auth
hellspawn679 Jun 16, 2024
4e4450c
reverting back
hellspawn679 Jun 16, 2024
279ab59
added flags for auth
hellspawn679 Jun 16, 2024
e2cf82e
Merge branch 'main' into auth
hellspawn679 Jun 17, 2024
504ac07
updated integration test for cassandra
hellspawn679 Jun 17, 2024
1959b26
added flags
hellspawn679 Jun 17, 2024
31a8da3
Merge branch 'main' into auth
hellspawn679 Jun 17, 2024
0c892c7
update flag description
hellspawn679 Jun 17, 2024
82204d4
updated flag
hellspawn679 Jun 17, 2024
08ed6a6
Merge branch 'jaegertracing:main' into auth
hellspawn679 Jun 22, 2024
047c945
updated
Jun 25, 2024
7b0ad89
Merge branch 'main' of https://github.com/hellspawn679/jaeger
Jun 27, 2024
db5f04b
increase codecov
Jun 27, 2024
ee78dbe
updated
Jun 27, 2024
d6efe4f
testing_for_plain_test
Jun 27, 2024
a2b5373
updated
Jun 28, 2024
56b91c2
Merge branch 'main' into code_cov
hellspawn679 Jun 28, 2024
07ab8d4
fixed goleak
Jun 29, 2024
2b43f34
increase code_cov
Jun 29, 2024
56e1630
tls fail case
Jun 29, 2024
a498277
minor change
Jun 29, 2024
855892f
increase plaintest code_cov
Jun 30, 2024
db6d2ba
added test for kafka consumer
Jun 30, 2024
ffce2af
Merge branch 'main' into code_cov
hellspawn679 Jun 30, 2024
57ff7d0
fixed
Jun 30, 2024
ab430f0
increase consumer code cov
Jun 30, 2024
9ed2d3a
added test for kafka producer
Jun 30, 2024
e61a8d8
simplified the code
Jul 1, 2024
0bae39e
Merge branch 'main' into code_cov
hellspawn679 Jul 1, 2024
cdb5556
fixed
Jul 2, 2024
8d806bb
Merge branch 'main' into code_cov
hellspawn679 Jul 2, 2024
25bc2fa
Merge branch 'main' into code_cov
yurishkuro Jul 3, 2024
e067769
fixed
Jul 3, 2024
e7a0875
Merge branch 'code_cov' of https://github.com/hellspawn679/jaeger int…
Jul 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
added more options auth for cassandra
Signed-off-by: mehul gautam <[email protected]>
  • Loading branch information
hellspawn679 committed Jun 14, 2024
commit 7bb82592ebc979083d06111bf88ff20e7789e12f
20 changes: 18 additions & 2 deletions pkg/cassandra/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,21 @@
TLS tlscfg.Options `mapstructure:"tls"`
}

var (
defaultApprovedAuthenticators = []string{
"org.apache.cassandra.auth.PasswordAuthenticator",
"com.instaclustr.cassandra.auth.SharedSecretAuthenticator",
"com.datastax.bdp.cassandra.auth.DseAuthenticator",
"io.aiven.cassandra.auth.AivenAuthenticator",
"com.ericsson.bss.cassandra.ecaudit.auth.AuditPasswordAuthenticator",
"com.amazon.helenus.auth.HelenusAuthenticator",
"com.ericsson.bss.cassandra.ecaudit.auth.AuditAuthenticator",
"com.scylladb.auth.SaslauthdAuthenticator",
"com.scylladb.auth.TransitionalAuthenticator",
"com.instaclustr.cassandra.auth.InstaclustrPasswordAuthenticator",
}
)

// Authenticator holds the authentication properties needed to connect to a Cassandra cluster
type Authenticator struct {
Basic BasicAuthenticator `yaml:"basic" mapstructure:",squash"`
Expand Down Expand Up @@ -143,8 +158,9 @@

if c.Authenticator.Basic.Username != "" && c.Authenticator.Basic.Password != "" {
cluster.Authenticator = gocql.PasswordAuthenticator{
Username: c.Authenticator.Basic.Username,
Password: c.Authenticator.Basic.Password,
Username: c.Authenticator.Basic.Username,
Password: c.Authenticator.Basic.Password,
AllowedAuthenticators: defaultApprovedAuthenticators,

Check warning on line 163 in pkg/cassandra/config/config.go

View check run for this annotation

Codecov / codecov/patch

pkg/cassandra/config/config.go#L161-L163

Added lines #L161 - L163 were not covered by tests
}
}
tlsCfg, err := c.TLS.Config(logger)
Expand Down
Loading