Increase codecov of pkg/kafka #5682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5682 +/- ##
==========================================
+ Coverage 96.42% 96.88% +0.45%
==========================================
Files 334 334
Lines 16144 16144
==========================================
+ Hits 15567 15641 +74
+ Misses 402 334 -68
+ Partials 175 169 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: mehul gautam <[email protected]>
yurishkuro
added
the
changelog:test
yurishkuro
reviewed
Jun 27, 2024
Signed-off-by: mehul gautam <[email protected]>
yurishkuro
reviewed
Jun 27, 2024
yurishkuro
reviewed
Jun 28, 2024
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
yurishkuro
reviewed
Jun 30, 2024
yurishkuro
reviewed
Jun 30, 2024
yurishkuro
reviewed
Jun 30, 2024
yurishkuro
reviewed
Jun 30, 2024
added 2 commits
June 30, 2024 18:36
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
hellspawn679
commented
Jun 30, 2024
Signed-off-by: mehul gautam <[email protected]>
yurishkuro
reviewed
Jul 1, 2024
yurishkuro
reviewed
Jul 1, 2024
Signed-off-by: mehul gautam <[email protected]>
yurishkuro
reviewed
Jul 1, 2024
pkg/kafka/auth/config_test.go
Outdated
Comment on lines
98
to
105
| "--kafka.auth.kerberos.service-name=kafka", | ||
| "--kafka.auth.kerberos.realm=EXAMPLE.COM", | ||
| "--kafka.auth.kerberos.use-keytab=true", | ||
| "--kafka.auth.kerberos.username=user", | ||
| "--kafka.auth.kerberos.password=password", | ||
| "--kafka.auth.kerberos.config-file=/path/to/krb5.conf", | ||
| "--kafka.auth.kerberos.keytab-file=/path/to/keytab", | ||
| "--kafka.auth.kerberos.disable-fast-negotiation=true", |
There was a problem hiding this comment.
is kerberos relevant to this test? the tests should use minimal amount of settings required to reproduce the scenario
There was a problem hiding this comment.
If you are testing different permutations of settings, it's better to make this table-driven and include only the right amount of settings for each use case
Signed-off-by: mehul gautam <[email protected]>
yurishkuro
reviewed
Jul 3, 2024
pkg/kafka/auth/tls_test.go
Outdated
| tlsConfig := &tlscfg.Options{ | ||
| Enabled: true, | ||
| } | ||
| defer tlsConfig.Close() |
There was a problem hiding this comment.
this should be after the call to setTLSConfiguration and error check. At this point you just created a struct, there can be no goroutine leak yet.
yurishkuro
reviewed
Jul 3, 2024
yurishkuro
reviewed
Jul 3, 2024
yurishkuro
reviewed
Jul 3, 2024
pkg/kafka/auth/plaintext_test.go
Outdated
| expectedMechanism sarama.SASLMechanism | ||
| }{ | ||
| { | ||
| name: "SCRAM-SHA-256", |
There was a problem hiding this comment.
name field is redundant, you can use config.Mechanism instead
added 2 commits
July 3, 2024 05:55
Signed-off-by: mehul gautam <[email protected]>
yurishkuro
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
pkg/kafka/auth/config.goand updatedinternal/tracegen/worker_test.goHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test