Set desired providers/converters instead of relying on defaults #5543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Helmuth <[email protected]>
TylerHelmuth
force-pushed
the
set-collector-providers
branch
from
e8b1820 to
daaad63
Compare
yurishkuro
approved these changes
Jun 6, 2024
yurishkuro
reviewed
Jun 6, 2024
| @@ -30,6 +37,20 @@ func Command() *cobra.Command { | |||
| settings := otelcol.CollectorSettings{ | |||
| BuildInfo: info, | |||
| Factories: Components, | |||
| ConfigProviderSettings: otelcol.ConfigProviderSettings{ | |||
There was a problem hiding this comment.
why couldn't this be the default?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 327 327
Lines 16007 16021 +14
=======================================
+ Hits 15399 15413 +14
Misses 432 432
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
approved these changes
Jun 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Related to open-telemetry/opentelemetry-collector#10290
Description of the changes
Updates the
otelcol.CollectorSettingspassed tootelcol.NewCommandto include desired providers and converters instead of relying onotelcol.NewCommandto provide defaults.These providers/converters as the exact same being set by defaults here, which will probably stop getting set in the future.
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test