Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Set desired providers/converters instead of relying on defaults (#5543)
## Which problem is this PR solving? Related to open-telemetry/opentelemetry-collector#10290 ## Description of the changes Updates the `otelcol.CollectorSettings` passed to `otelcol.NewCommand` to include desired providers and converters instead of relying on `otelcol.NewCommand` to provide defaults. These providers/converters as the exact same being set by defaults [here](https://github.com/open-telemetry/opentelemetry-collector/blob/6888f8f7a45fd6dff4dfc29a82802c95459f619c/otelcol/configprovider.go#L134), which will probably stop getting set in the future. ## How was this change tested? - unit tests ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Tyler Helmuth <[email protected]>
- Loading branch information