Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip linting on Go tip #4338

Merged
merged 1 commit into from
Mar 25, 2023
+8 −2
Merged

Skip linting on Go tip #4338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Skip linting on Go tip 
Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
@yurishkuro
yurishkuro committed Mar 25, 2023
commit 9ac71212d0b5c38a699d2d36fdce827c94d1eeaf
3 changes: 3 additions & 0 deletions .github/workflows/ci-unit-tests-go-tip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,6 @@ jobs:

- name: Run unit tests
run: make test-ci

- name: Lint
run: echo skip linting on Go tip
3 changes: 3 additions & 0 deletions .github/workflows/ci-unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,6 @@ jobs:
flags: unittests
fail_ci_if_error: true
token: ${{ env.CODECOV_TOKEN }}

- name: Lint
run: make lint
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,14 +394,14 @@ draft-release:
.PHONY: install-tools
install-tools:
$(GO) install github.com/vektra/mockery/[email protected]
$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.2
$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.1
$(GO) install mvdan.cc/gofumpt@latest

.PHONY: install-ci
install-ci: install-tools

.PHONY: test-ci
test-ci: build-examples cover lint
test-ci: build-examples cover

.PHONY: thrift
thrift: idl/thrift/jaeger.thrift thrift-image
Expand Down