Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip linting on Go tip #4338

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Skip linting on Go tip #4338

merged 1 commit into from
Mar 25, 2023

Conversation

yurishkuro
Copy link
Member

golangci-lint doesn't seem to like running against Go tip: https://github.com/jaegertracing/jaeger/actions/runs/4517523436/jobs/7956780871#step:7:5416

The errors are actually invalid, since typecheck is not a linter, it flags compile errors, but unit tests run fine.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro requested a review from a team as a code owner March 25, 2023 05:52
@yurishkuro yurishkuro requested a review from pavolloffay March 25, 2023 05:52
@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (17f34b7) 97.08% compared to head (9ac7121) 97.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4338      +/-   ##
==========================================
- Coverage   97.08%   97.06%   -0.03%     
==========================================
  Files         300      300              
  Lines       17697    17697              
==========================================
- Hits        17182    17178       -4     
- Misses        414      417       +3     
- Partials      101      102       +1     
Flag Coverage Δ
unittests 97.06% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 4f231b6 into jaegertracing:main Mar 25, 2023
@yurishkuro yurishkuro deleted the linting branch March 25, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant