Prepare release v1.43.0 #4298

pavolloffay · 2023-03-13T10:28:10Z

TODOs

Update UI once Prepare release v1.28.0 jaeger-ui#1264 is merged

codecov · 2023-03-13T10:37:25Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (87098d1) 97.10% compared to head (9fc3d3e) 97.09%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4298      +/-   ##
==========================================
- Coverage   97.10%   97.09%   -0.01%     
==========================================
  Files         300      300              
  Lines       17659    17659              
==========================================
- Hits        17147    17146       -1     
- Misses        412      413       +1     
  Partials      100      100

Flag	Coverage Δ
unittests	`97.09% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Pavol Loffay <[email protected]>

CHANGELOG.md

albertteoh · 2023-03-15T09:52:08Z

CHANGELOG.md

+* Updating all-in-one path ([@bigfleet](https://github.com/bigfleet) in [#4234](https://github.com/jaegertracing/jaeger/pull/4234))
+* Migrate the use of fsnotify to fswatcher in cert_watcher.go ([@haanhvu](https://github.com/haanhvu) in [#4232](https://github.com/jaegertracing/jaeger/pull/4232))
+* Restore baggage support in HotROD 🚗 ([@yurishkuro](https://github.com/yurishkuro) in [#4225](https://github.com/jaegertracing/jaeger/pull/4225))
+* Jaeger YugabyteDB(YCQL) support ([@HarshDaryani896](https://github.com/HarshDaryani896) in [#4220](https://github.com/jaegertracing/jaeger/pull/4220))


This sounds like a new feature to me, what does everyone think?

Signed-off-by: Pavol Loffay <[email protected]>

pavolloffay · 2023-03-15T10:24:27Z

@albertteoh thanks for the review. PR updated

albertteoh

LGTM

albertteoh · 2023-03-15T10:37:19Z

CHANGELOG.md

@@ -13,6 +13,31 @@ next release

 ### UI Changes

+1.43.0 (2023-03-13)


Update to today's date?

Signed-off-by: Pavol Loffay <[email protected]>

pavolloffay · 2023-03-15T12:25:27Z

The UI test Check_if_the_favicon_icon_is_available is failing and the UI does not load if I run it locally go run -tags ui ./cmd/all-in-one/main.go

yurishkuro · 2023-03-15T14:43:36Z

@mszabo-wikia I remember icon file moved in the UI recently

pavolloffay · 2023-03-15T14:44:31Z

I think this is the root cause jaegertracing/jaeger-ui#1275

yurishkuro · 2023-03-15T15:10:53Z

So the icon file is now legitimately gone, because it's embedded directly in HTML:

<link rel="shortcut icon" href="data:image/x-icon;base64,AAAB......A==">

However, the UI loads with a blank screen for me (tried both with and without ui prefix).

yurishkuro · 2023-03-15T15:12:32Z

@pavolloffay do you want to just downgrade UI to 1.27.4 and get the release out? It might take time to figure out how the UI build changed.

yurishkuro · 2023-03-15T15:23:00Z

Check_if_the_favicon_icon_is_available

I'm glad we had this test :-). It won't work going forward, but the situation with the blank screen in the UI makes me think we should alter it to look for some other specific element in the UI home page. Ideally it would be something like the Search button, which would only be generated if the correct React app is loaded, but that won't happen via curl.

yurishkuro · 2023-03-15T15:31:45Z

I added a bit of logging to static handler, things look ok from the server side

serving /static/index-b9997246.js
serving /static/index-3c2d679b.css

and in Chrome too:

I think it's really something about the UI build output, the app is incomplete or we're using a wrong mode.

@mszabo-wikia any thoughts?

mszabo-wikia · 2023-03-15T15:38:14Z

@yurishkuro Interesting, I remember checking the production build case with a local all-in-one install & there were no issues then. Will retest that to see what changed.

mszabo-wikia · 2023-03-15T15:45:56Z

Looks like there's this error:

Uncaught TypeError: Unknown theme type: undefined, name: undefined
    withSuffix http://localhost:16686/static/index-b9997246.js:69

mszabo-wikia · 2023-03-15T15:55:14Z

Although ant-design/ant-design#19002 (comment) is in Chinese, it seems the observed error matches & from some quick local testing the UI loads properly after applying that update to the build config. So this looks to be an antd 3.9.0 -> 3.26 update regression.

mszabo-wikia · 2023-03-15T16:08:24Z

Filed jaegertracing/jaeger-ui#1276. ee7ce64f6784e5e00718a58680a43098f83a3c94 is the first commit that breaks without the additional config, so antd 3.26 indeed seems to be at fault.

Signed-off-by: Pavol Loffay <[email protected]>

yurishkuro

I expect favicon test would still fail, need to remove it

Signed-off-by: Pavol Loffay <[email protected]>

yurishkuro · 2023-03-15T18:06:05Z

cmd/all-in-one/all_in_one_test.go

 	t.Log("Checking favicon...")
-	resp, err := http.Get(queryURL + "/favicon.ico")
+	resp, err := http.Get(queryURL + "/static/jaeger-logo-ab11f618.svg")


I wonder if the hash in the filename may change over time and break this test. If it's based on the file checksum then it should be stable. We can improve the test later, e.g. request home page first, and look for logo URL in HTML.

the hash should not change if the logo does not change

pavolloffay marked this pull request as ready for review March 15, 2023 09:35

pavolloffay requested a review from a team as a code owner March 15, 2023 09:35

pavolloffay requested a review from vprithvi March 15, 2023 09:35

pavolloffay added 2 commits March 15, 2023 10:35

Prepare release v1.43.0

f982484

Signed-off-by: Pavol Loffay <[email protected]>

Update UI

fec6085

Signed-off-by: Pavol Loffay <[email protected]>

pavolloffay force-pushed the release-1.43 branch from e30337e to fec6085 Compare March 15, 2023 09:43

albertteoh reviewed Mar 15, 2023

View reviewed changes

Fix

630eb55

Signed-off-by: Pavol Loffay <[email protected]>

albertteoh previously approved these changes Mar 15, 2023

View reviewed changes

Update date

99ff576

Signed-off-by: Pavol Loffay <[email protected]>

pavolloffay dismissed albertteoh’s stale review via 99ff576 March 15, 2023 10:39

albertteoh previously approved these changes Mar 15, 2023

View reviewed changes

UI 1.28.1

ec726b1

Signed-off-by: Pavol Loffay <[email protected]>

pavolloffay dismissed albertteoh’s stale review via ec726b1 March 15, 2023 17:18

yurishkuro previously approved these changes Mar 15, 2023

View reviewed changes

Change favicon test

9fc3d3e

Signed-off-by: Pavol Loffay <[email protected]>

pavolloffay dismissed yurishkuro’s stale review via 9fc3d3e March 15, 2023 17:45

yurishkuro approved these changes Mar 15, 2023

View reviewed changes

pavolloffay merged commit d1cf716 into jaegertracing:main Mar 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare release v1.43.0 #4298

Prepare release v1.43.0 #4298

pavolloffay commented Mar 13, 2023 •

edited

Loading

codecov bot commented Mar 13, 2023 •

edited

Loading

albertteoh Mar 15, 2023

pavolloffay commented Mar 15, 2023

albertteoh left a comment

albertteoh Mar 15, 2023

pavolloffay Mar 15, 2023

pavolloffay commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

pavolloffay commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

mszabo-wikia commented Mar 15, 2023

mszabo-wikia commented Mar 15, 2023

mszabo-wikia commented Mar 15, 2023

mszabo-wikia commented Mar 15, 2023

yurishkuro left a comment

yurishkuro Mar 15, 2023

pavolloffay Mar 15, 2023

		@@ -13,6 +13,31 @@ next release

		### UI Changes

		1.43.0 (2023-03-13)

Prepare release v1.43.0 #4298

Prepare release v1.43.0 #4298

Conversation

pavolloffay commented Mar 13, 2023 • edited Loading

codecov bot commented Mar 13, 2023 • edited Loading

Codecov Report

albertteoh Mar 15, 2023

Choose a reason for hiding this comment

pavolloffay commented Mar 15, 2023

albertteoh left a comment

Choose a reason for hiding this comment

albertteoh Mar 15, 2023

Choose a reason for hiding this comment

pavolloffay Mar 15, 2023

Choose a reason for hiding this comment

pavolloffay commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

pavolloffay commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

yurishkuro commented Mar 15, 2023

mszabo-wikia commented Mar 15, 2023

mszabo-wikia commented Mar 15, 2023

mszabo-wikia commented Mar 15, 2023

mszabo-wikia commented Mar 15, 2023

yurishkuro left a comment

Choose a reason for hiding this comment

yurishkuro Mar 15, 2023

Choose a reason for hiding this comment

pavolloffay Mar 15, 2023

Choose a reason for hiding this comment

pavolloffay commented Mar 13, 2023 •

edited

Loading

codecov bot commented Mar 13, 2023 •

edited

Loading