Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v1.28.0 #1264

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Conversation

pavolloffay
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (947c145) 95.52% compared to head (66452fd) 95.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   95.52%   95.40%   -0.12%     
==========================================
  Files         244      244              
  Lines        7753     7753              
  Branches     2016     2016              
==========================================
- Hits         7406     7397       -9     
- Misses        347      356       +9     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGELOG.md Outdated
@@ -6,6 +6,38 @@

### Fixes

## v1.28.0 (2023-03-13)

- Bump jsdom from 21.1.0 to 21.1.1 ([@dependabot](https://github.com/dependabot) in [#1257](https://github.com/jaegertracing/jaeger-ui/pull/1257))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove these dependabot changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, although the previous release lists some of them.

We should document this in the release.md.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I suspect they might have been relevant to the patch release, though.


### Enhancements

### Fixes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2bf0392 - Prevent wrapping of the timeline tick label text (#1117) (5 weeks ago) <Jonathan Chan Kwan Yin>
f3da647 - Move alt view dropdown to a button (#1174) (5 weeks ago) <Sergio Mira Muñoz>

(not sure if the last one is Fix or Enhancement)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added - see my previous comment

yurishkuro
yurishkuro previously approved these changes Mar 14, 2023
CHANGELOG.md Outdated

### Enhancements

- Make traceID, startTime, endTime, duration and traceName available fo… ([@MUI-Pop](https://github.com/MUI-Pop) in [#1178](https://github.com/jaegertracing/jaeger-ui/pull/1178))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Make traceID, startTime, endTime, duration and traceName available fo… ([@MUI-Pop](https://github.com/MUI-Pop) in [#1178](https://github.com/jaegertracing/jaeger-ui/pull/1178))
- Make traceID, startTime, endTime, duration and traceName available for Link Patterns ([@MUI-Pop](https://github.com/MUI-Pop) in [#1178](https://github.com/jaegertracing/jaeger-ui/pull/1178))

Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay
Copy link
Member Author

PR updated with the latest changes in the main. I will merge it to proceed with the release as the PR was already approved.

@pavolloffay pavolloffay merged commit 543de7a into jaegertracing:main Mar 15, 2023
Binrix pushed a commit to Binrix/jaeger-ui that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants