Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix cache resolution and syntax in check binary size workflow #2591

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[CI] Fix cache resolution and syntax in check binary size workflow #2591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/check_bundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@ jobs:
with:
path: bundle_size.txt
key: jaeger-ui-bundle-size
restore-keys: |
jaeger-ui-bundle-size

- name: Compare bundle sizes
if: steps.cache-bundle-size.outputs.cache-hit == 'true'
if: steps.cache-bundle-size.outputs.cache-matched-key != ''
run: |
OLD_BUNDLE_SIZE=$(cat bundle_size.txt)
NEW_BUNDLE_SIZE=$(cat new_bundle_size.txt)
Expand All @@ -62,8 +64,8 @@ jobs:
run: mv new_bundle_size.txt bundle_size.txt

- name: Save new bundle size
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
if: ${{ (github.event_name == 'push') && (github.ref == 'refs/heads/main') }}
uses: actions/cache/save@v4
with:
path: bundle_size.txt
key: jaeger-ui-bundle-size
key: jaeger-ui-bundle-size-${{ github.run_id }}
Loading