Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix cache resolution and syntax in check binary size workflow #2591

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: chahatsagarmain <[email protected]>
@chahatsagarmain chahatsagarmain requested a review from a team as a code owner January 16, 2025 17:03
@chahatsagarmain chahatsagarmain requested review from joe-elliott and removed request for a team January 16, 2025 17:03
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jan 17, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) January 17, 2025 04:14
@yurishkuro yurishkuro merged commit 1178b1c into jaegertracing:main Jan 17, 2025
8 of 9 checks passed
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (1ee19c2) to head (694298e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2591   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         255      255           
  Lines        7732     7732           
  Branches     1944     1996   +52     
=======================================
  Hits         7468     7468           
  Misses        264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hari45678
Copy link
Contributor

@yurishkuro This PR is creating new cache key on each commit to the main branch. That would result in cache miss on subsequent PRs.

@yurishkuro
Copy link
Member

it does create new key, but it uses a pattern-match to find them which picks the latest. Using a fixed key for some reason means cache will not be updated after the first value.

@hari45678
Copy link
Contributor

Yes, but it isn't picking up the latest cache key in this (jaeger-ui) repository, maybe because here exists an exact key match, so it is picking up that stale cache.
For example, in bundle check workflow in this PR #2593, the action is picking up the key jaeger-ui-bundle-size, and not the latest key jaeger-ui-bundle-size-12822565240 which was created with bundle check action trigger with latest push to main branch after this PR was merged.

@yurishkuro
Copy link
Member

Then we still don't have a solution

@chahatsagarmain
Copy link
Contributor Author

chahatsagarmain commented Jan 18, 2025

@yurishkuro we need to delete the old exact key match , from action -> caches and the new restores should be done from this change .

@hari45678
Copy link
Contributor

@yurishkuro we need to delete the old exact key match , from action -> caches .

yes that should solve this issue

@yurishkuro
Copy link
Member

deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI]: Improper cache resolution and conditional statement handling in check bundle size workflow .
3 participants