-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix cache resolution and syntax in check binary size workflow #2591
Conversation
Signed-off-by: chahatsagarmain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2591 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 255 255
Lines 7732 7732
Branches 1944 1996 +52
=======================================
Hits 7468 7468
Misses 264 264 ☔ View full report in Codecov by Sentry. |
@yurishkuro This PR is creating new cache key on each commit to the main branch. That would result in cache miss on subsequent PRs. |
it does create new key, but it uses a pattern-match to find them which picks the latest. Using a fixed key for some reason means cache will not be updated after the first value. |
Yes, but it isn't picking up the latest cache key in this (jaeger-ui) repository, maybe because here exists an exact key match, so it is picking up that stale cache. |
Then we still don't have a solution |
@yurishkuro we need to delete the old exact key match , from action -> caches and the new restores should be done from this change . |
yes that should solve this issue |
deleted |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test