Run test cases correctly #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since itamae-kitchen#281 , spec for integration tests are not executed. Because the pattern is not correct. `[default|docker]` is bad for OR pattern. It should be `{default,docker}`. It was introduced by me. I'm sorry🙇🙇 Before === ```console $ bundle exec rake spec:integration:ubuntu:trusty (snip) /home/pocke/.rbenv/versions/trunk/bin/ruby -I ./spec/integration -I/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/lib:/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-support-3.8.0/lib /home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/exe/rspec --pattern spec/integration/\[default\|docker\]_spec.rb No examples found. Finished in 0.00016 seconds (files took 0.03293 seconds to load) 0 examples, 0 failures ``` After === ```console $ bundle exec rake spec:integration:ubuntu:trusty (snip) /home/pocke/.rbenv/versions/trunk/bin/ruby -I ./spec/integration -I/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/lib:/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-support-3.8.0/lib /home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/exe/rspec --pattern spec/integration/\{default,docker\}_spec.rb (snip) Finished in 13.9 seconds (files took 0.28032 seconds to load) 139 examples, 0 failures ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #281 , spec for integration tests are not executed.
Because the pattern is not correct.
[default|docker]is bad for OR pattern.It should be
{default,docker}.https://relishapp.com/rspec/rspec-core/v/3-8/docs/command-line/pattern-option#the-%60--pattern%60-flag-accepts-shell-style-glob-unions
This change makes the test cases to be executed.
It was introduced by me. I'm sorry🙇🙇
Before
After