Add integration test with `itamae local` command #281

pocke · 2019-01-13T11:55:02Z

Problem

We don't have any integration test for itamae local command, so we cannot test #277.

Solution

Add an integation test for itamae local command.

Strategy:

Start a docker container for the test.
Execute itamae local comamnd in the container.
Execute the serverspec from the host machine.

Goal of this pull request

Add integration test script.
Run this test on CI
Make the test cases green with itamae local also
Add test case for Make send_file aware of user option #277 (maybe I should work this todo on Make send_file aware of user option #277 )

pocke · 2019-01-13T12:34:58Z

spec/integration/default_spec.rb

@@ -206,7 +178,7 @@
 end

 describe command('gem list') do
-  its(:stdout) { should include('rake (11.1.0)') }
+  its(:stdout) { should match(/^rake \(.*11.1.0.*\)/) }


Another rake version is installed in the docker image that is used for itamae local command test, so relax the test.

pocke · 2019-01-13T12:36:28Z

spec/integration/recipes/local.rb

@@ -0,0 +1,10 @@
+package 'sl' do
+  version '3.03-17+b2'


ruby docker image does not have sl package version 3.03-17, it only has 3.03-17+b2.

pocke · 2019-01-13T12:39:03Z

spec/integration/recipes/local.rb

+
+gem_package 'bundler' do
+  version '1.17.3'
+  options ['--no-document']


New rubygems, which is installed in ruby docker image, does not have --no-rdoc and --no-ri options. So use --no-document option instead.

Note: Ubuntu trusty, which is used in the existing integration test, installs Ruby 1.9.3!!!!! Rubygems on Ruby 1.9.3 has --no-rodc and --no-ri options 🙃 .

pocke · 2019-01-13T12:54:41Z

.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 sudo: required
+dist: xenial


Need upgrading ubuntu version to use new version docker.
In trusty, docker exec does not have --workdir option, so I upgraded it to xenial.

Because bundler is too special gem, I got an unexpected and mysterious error with bundler, so I replaced bundler with ast, which is not a special gem.

pocke · 2019-01-13T14:17:10Z

tasks/integration_local_spec.rb

+
+  def docker_run
+    mount_dir = Pathname(__dir__).join('../').to_s
+    sh 'docker', 'run', '--privileged', '-d', '--name', CONTAINER_NAME, '-v', "#{mount_dir}:/itamae", "ruby:#{@ruby_version}", 'sleep', '1d'


sleep command is a hack...
/sbin/init is used for the existing integration test, but the image does not have /sbin/init.
So use sleep command instead.

Because `ruby:2.7` image does not exist until releasing Ruby 2.7

pocke · 2019-01-13T14:54:52Z

I think this pull request is ready to review. Can you review this pull request?

I still have an unchecked TODO, but I will work on the todo on #277 .

sue445 · 2019-01-13T15:28:41Z

Rakefile

@@ -64,7 +69,7 @@ namespace :spec do
        RSpec::Core::RakeTask.new(target.to_sym) do |t|
          ENV['DOCKER_CONTAINER'] = container_name
          t.ruby_opts = '-I ./spec/integration'
-          t.pattern = "spec/integration/*_spec.rb"
+          t.pattern = "spec/integration/[default|docker]_spec.rb"


Is this necessary?

Even without changing here, I think that default_spec.rb and docker_spec.rbwill be executed.

Currently, it is unnecessary, but I think it is necessary in the near future.
Because I'll add a test case(s) for #277 , and serverspec file. Probably the new serverspec file is needed only by the new test. Test for itamae docker should not load the new serverspec file, so it's necessary.

unasuke

🕺

sue445 · 2019-01-15T14:01:00Z

@pocke Can I merge this PR?

pocke · 2019-01-15T14:27:21Z

@pocke Can I merge this PR?

Sure! Thanks for your reviewing!

Since itamae-kitchen#281 , spec for integration tests are not executed. Because the pattern is not correct. `[default|docker]` is bad for OR pattern. It should be `{default,docker}`. It was introduced by me. I'm sorry🙇🙇 Before === ```console $ bundle exec rake spec:integration:ubuntu:trusty (snip) /home/pocke/.rbenv/versions/trunk/bin/ruby -I ./spec/integration -I/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/lib:/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-support-3.8.0/lib /home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/exe/rspec --pattern spec/integration/\[default\|docker\]_spec.rb No examples found. Finished in 0.00016 seconds (files took 0.03293 seconds to load) 0 examples, 0 failures ``` After === ```console $ bundle exec rake spec:integration:ubuntu:trusty (snip) /home/pocke/.rbenv/versions/trunk/bin/ruby -I ./spec/integration -I/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/lib:/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-support-3.8.0/lib /home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/exe/rspec --pattern spec/integration/\{default,docker\}_spec.rb (snip) Finished in 13.9 seconds (files took 0.28032 seconds to load) 139 examples, 0 failures ```

[WIP] Add integration test with itamae local command

5f307bf

pocke mentioned this pull request Jan 13, 2019

Make send_file aware of user option #277

Merged

pocke added 5 commits January 13, 2019 21:05

Receive ruby_version outside the class

6525574

Separate failing tests between itame local and itamae docker

3ef30bc

Fix serverspec for itamae local command

35ab4b3

Replace ivar with const

3dd8161

Improve container alive detection

381c81a

pocke force-pushed the test-local branch from ef8d5ea to 381c81a Compare January 13, 2019 12:27

Run spec:integration:local with rake spec

8cc9f37

pocke commented Jan 13, 2019

View reviewed changes

Try to use xenial on Travis

fe9925a

pocke commented Jan 13, 2019

View reviewed changes

pocke force-pushed the test-local branch 2 times, most recently from 9dc4102 to 427bf88 Compare January 13, 2019 14:00

pocke added 3 commits January 13, 2019 23:12

Drop teeny version for docker image

b6a807a

Simplify starting docker with -d option

dcc693e

Use ast instead of bundler to installing gem test

b8a8305

Because bundler is too special gem, I got an unexpected and mysterious error with bundler, so I replaced bundler with ast, which is not a special gem.

pocke force-pushed the test-local branch from 427bf88 to b8a8305 Compare January 13, 2019 14:13

pocke commented Jan 13, 2019

View reviewed changes

Skip the integration test with ruby-head

3d1042b

Because `ruby:2.7` image does not exist until releasing Ruby 2.7

pocke changed the title ~~[WIP] Add integration test with itamae local command~~ Add integration test with itamae local command Jan 13, 2019

sue445 requested review from sue445 and unasuke January 13, 2019 14:56

sue445 reviewed Jan 13, 2019

View reviewed changes

sue445 approved these changes Jan 13, 2019

View reviewed changes

unasuke approved these changes Jan 15, 2019

View reviewed changes

sue445 merged commit efda69f into itamae-kitchen:master Jan 15, 2019

pocke deleted the test-local branch January 15, 2019 14:54

pocke mentioned this pull request May 10, 2019

Run test cases correctly #289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integration test with `itamae local` command #281

Add integration test with `itamae local` command #281

pocke commented Jan 13, 2019 •

edited

Loading

pocke Jan 13, 2019

pocke Jan 13, 2019

pocke Jan 13, 2019

pocke Jan 13, 2019 •

edited

Loading

pocke Jan 13, 2019

pocke commented Jan 13, 2019

sue445 Jan 13, 2019

pocke Jan 13, 2019

unasuke left a comment

sue445 commented Jan 15, 2019

pocke commented Jan 15, 2019

Add integration test with itamae local command #281

Add integration test with itamae local command #281

Conversation

pocke commented Jan 13, 2019 • edited Loading

Problem

Solution

Goal of this pull request

pocke Jan 13, 2019

Choose a reason for hiding this comment

pocke Jan 13, 2019

Choose a reason for hiding this comment

pocke Jan 13, 2019

Choose a reason for hiding this comment

pocke Jan 13, 2019 • edited Loading

Choose a reason for hiding this comment

pocke Jan 13, 2019

Choose a reason for hiding this comment

pocke commented Jan 13, 2019

sue445 Jan 13, 2019

Choose a reason for hiding this comment

pocke Jan 13, 2019

Choose a reason for hiding this comment

unasuke left a comment

Choose a reason for hiding this comment

sue445 commented Jan 15, 2019

pocke commented Jan 15, 2019

Add integration test with `itamae local` command #281

Add integration test with `itamae local` command #281

pocke commented Jan 13, 2019 •

edited

Loading

pocke Jan 13, 2019 •

edited

Loading