Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[77] Changed where keyword to lowercase (4-2-stable) #81

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[77] Changed where keyword to lowercase (4-2-stable) #81

merged 1 commit into from
Dec 11, 2023

Conversation

JustinKyleJames
Copy link

@JustinKyleJames JustinKyleJames commented Oct 17, 2023 •
edited
Loading

Cherry-picked from #78.

@alanking alanking changed the title [77] Changed where keyword to lowercase [77] Changed where keyword to lowercase (4-2-stable) Oct 17, 2023
korydraughn
korydraughn reviewed Oct 17, 2023
View reviewed changes
Copy link

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Let's hold on this until after 4.3.1.

@JustinKyleJames
Copy link
Author

JustinKyleJames commented Dec 8, 2023 •
edited
Loading

Looks fine.

Let's hold on this until after 4.3.1.

Are we ready to merge this now? I just retested this and it is good to go.

korydraughn
korydraughn approved these changes Dec 8, 2023
View reviewed changes
Copy link

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@JustinKyleJames
Copy link
Author

Pound it.

Done

@alanking alanking merged commit 57c0fd5 into irods:4-2-stable Dec 11, 2023
@JustinKyleJames JustinKyleJames deleted the issue_77_42stable branch April 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanking alanking alanking approved these changes

@korydraughn korydraughn korydraughn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinKyleJames @korydraughn @alanking