Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[77] Changed where keyword to lowercase (main) #78

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[77] Changed where keyword to lowercase (main) #78

merged 1 commit into from
Oct 17, 2023

Conversation

JustinKyleJames
Copy link

No description provided.

korydraughn
korydraughn approved these changes Oct 17, 2023
View reviewed changes
Copy link

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Do we have a test for this?

alanking
alanking reviewed Oct 17, 2023
View reviewed changes
Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes to test if applicable

@JustinKyleJames
Copy link
Author

Looks good.

Do we have a test for this?

We don't have automated testing for anything with this client. I put an entry in my test plan to test it.

korydraughn
korydraughn approved these changes Oct 17, 2023
View reviewed changes
Copy link

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

alanking
alanking approved these changes Oct 17, 2023
View reviewed changes
Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see... no tests. Okay, please # if confirmed working.

@alanking alanking changed the title [77] Changed where keyword to lowercase [77] Changed where keyword to lowercase (main) Oct 17, 2023
@korydraughn
Copy link

We don't have automated testing for anything with this client. I put an entry in my test plan to test it.

Consider creating an issue for adding automated tests.

@alanking alanking mentioned this pull request Oct 17, 2023
Merged
@JustinKyleJames JustinKyleJames mentioned this pull request Oct 17, 2023
Merged
@JustinKyleJames
Copy link
Author

We don't have automated testing for anything with this client. I put an entry in my test plan to test it.

Consider creating an issue for adding automated tests.

Done

@JustinKyleJames
Copy link
Author

Ah, I see... no tests. Okay, please # if confirmed working.

Done

@alanking alanking merged commit 77e962d into irods:main Oct 17, 2023
@trel
Copy link
Member

trel commented Oct 17, 2023

I see #82

@JustinKyleJames JustinKyleJames deleted the issue_77 branch December 7, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanking alanking alanking approved these changes

@korydraughn korydraughn korydraughn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustinKyleJames @korydraughn @trel @alanking