-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metalnx fixes 1 #377
Metalnx fixes 1 #377
Conversation
For posterity... jargon PR: DICE-UNC/jargon#497 Will review this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks like a lot of improvements in here.
Sorry if we've gone over this before, can't recall... Are there automated tests we can add for this, or is it mainly manual at this point? And speaking of which, have the issues in question been tested and shown to be fixed?
src/metalnx-web/src/main/java/com/emc/metalnx/controller/FilePropertiesController.java
Outdated
Show resolved
Hide resolved
src/metalnx-web/src/main/java/com/emc/metalnx/controller/FilePropertiesController.java
Outdated
Show resolved
Hide resolved
src/metalnx-web/src/main/java/com/emc/metalnx/controller/utils/GenQuerySearchUtil.java
Show resolved
Hide resolved
src/metalnx-web/src/main/java/com/emc/metalnx/controller/FilePropertiesController.java
Outdated
Show resolved
Hide resolved
Looks like this PR just needs the jargon and jargon-irods-ext PRs to land now. |
2212a7f
to
75c831a
Compare
src/metalnx-web/src/main/java/com/emc/metalnx/controller/PermissionsController.java
Outdated
Show resolved
Hide resolved
src/metalnx-web/src/main/java/com/emc/metalnx/controller/PermissionsController.java
Outdated
Show resolved
Hide resolved
src/metalnx-web/src/main/java/com/emc/metalnx/controller/PermissionsController.java
Outdated
Show resolved
Hide resolved
46c2953
to
fad284a
Compare
f5e33d3
to
0b1d7c2
Compare
I squashed the commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should wait for @korydraughn's approval before #'ing.
When #'ing, don't forget to add #'s to both issue numbers on that last commit so that they link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pound it.
Don't forget to add the pounds in the commit message body as mentioned by @alanking.
src/metalnx-web/src/main/java/com/emc/metalnx/controller/PermissionsController.java
Show resolved
Hide resolved
Defer to server.
- Update servlet.api version - Update node version - update dom4j version
0b1d7c2
to
d5ecd79
Compare
d5ecd79
to
5d4d8e7
Compare
This is to fix multiple issues as seen in the commits.
Notes: