Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metalnx fixes 1 #377

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Conversation

JustinKyleJames
Copy link
Contributor

@JustinKyleJames JustinKyleJames commented Feb 4, 2025

This is to fix multiple issues as seen in the commits.

Notes:

  1. The main issue with 307 has been resolved. I did not get all of the dependencies upgraded but did update some.
  2. The fix for 355 is a workaround for Jargon issue 495.
  3. I will add more issues before Trirods if time permits.
  4. This requires updates to both jargon and jargon-irods-ext. Pull requests for these have also been opened.

@alanking
Copy link

alanking commented Feb 4, 2025

For posterity...

jargon PR: DICE-UNC/jargon#497
jargon-irods-ext PR: DICE-UNC/jargon-irods-ext#49

Will review this soon.

Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like a lot of improvements in here.

Sorry if we've gone over this before, can't recall... Are there automated tests we can add for this, or is it mainly manual at this point? And speaking of which, have the issues in question been tested and shown to be fixed?

@korydraughn
Copy link
Contributor

Looks like this PR just needs the jargon and jargon-irods-ext PRs to land now.

@JustinKyleJames
Copy link
Contributor Author

I squashed the commits.

Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should wait for @korydraughn's approval before #'ing.

When #'ing, don't forget to add #'s to both issue numbers on that last commit so that they link.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

Don't forget to add the pounds in the commit message body as mentioned by @alanking.

@alanking alanking merged commit e02ec3e into irods-contrib:main Feb 11, 2025
1 check passed
@JustinKyleJames JustinKyleJames deleted the metalnx_fixes_1 branch February 11, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants