Metalnx fixes 1 #49
Merged
Metalnx fixes 1 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanking
reviewed
Feb 4, 2025
emc-metalnx-services/src/main/java/com/emc/metalnx/services/irods/UploadServiceImpl.java
Outdated
Show resolved
Hide resolved
emc-metalnx-services/src/main/java/com/emc/metalnx/services/irods/PermissionsServiceImpl.java
Outdated
Show resolved
Hide resolved
emc-metalnx-services/src/main/java/com/emc/metalnx/services/irods/PermissionsServiceImpl.java
Outdated
Show resolved
Hide resolved
emc-metalnx-services/src/main/java/com/emc/metalnx/services/irods/PermissionsServiceImpl.java
Show resolved
Hide resolved
korydraughn
reviewed
Feb 4, 2025
emc-metalnx-core/src/main/java/com/emc/metalnx/core/domain/entity/enums/DataGridPermType.java
Show resolved
Hide resolved
...metalnx-services/src/main/java/com/emc/metalnx/services/configuration/ConfigServiceImpl.java
Show resolved
Hide resolved
emc-metalnx-services/src/main/java/com/emc/metalnx/services/irods/PermissionsServiceImpl.java
Outdated
Show resolved
Hide resolved
emc-metalnx-services/src/main/java/com/emc/metalnx/services/irods/PermissionsServiceImpl.java
Outdated
Show resolved
Hide resolved
emc-metalnx-services/src/main/java/com/emc/metalnx/services/irods/UploadServiceImpl.java
Outdated
Show resolved
Hide resolved
emc-metalnx-services/src/main/java/com/emc/metalnx/services/irods/UserServiceImpl.java
Show resolved
Hide resolved
Other dependencies could be updated but they won't be at this time. I will update the commit message. |
JustinKyleJames
force-pushed
the
metalnx_fixes_1
branch
2 times, most recently
from
588f2b9 to
959876a
Compare
|
Commits have been squashed. |
alanking
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Looks good to me. Probably should wait for @korydraughn's approval before #'ing.
…() order to default user to RODS_USER
JustinKyleJames
force-pushed
the
metalnx_fixes_1
branch
from
959876a to
9159494
Compare
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes needed for Metalnx.