Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
(sorry, clicked the "open PR" button too fast)
This PR adds support for WIT files https://github.com/WebAssembly/component-model/blob/main/design/mvp/WIT.md, used by WebAssembly components to generate bindings via https://github.com/bytecodealliance/wit-bindgen
Today,
.wit
files are trimmed bycrane
, which meansbindgen
macro cannot find them (it searches by paths) in the project being built, but, more importantly, in dependencies (here's an example https://github.com/wasmCloud/wasmCloud/actions/runs/4415710680/jobs/7739037159An example of an "unbuildable" WIT-enabled Rust project, which is often included as a depedency is https://github.com/bytecodealliance/preview2-prototyping
Would this PR be something you'd be interested in merging @ipetkov ?
Checklist
docs/API.md
(or general documentation) with changesCHANGELOG.md