Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

fix: symlink wit, rather than using relative paths #134

Closed
wants to merge 1 commit into from

Conversation

rvolosatovs
Copy link
Member

This enables downstream builds utilizing cargo vendor, since cargo vendor resolves symlinks before packaging crates up

Closes #133

This enables downstream builds utilizing `cargo vendor`, since
`cargo vendor` resolves symlinks before packaging crates up

Signed-off-by: Roman Volosatovs <[email protected]>
@rvolosatovs
Copy link
Member Author

Thanks @ipetkov for 100% correct analysis of this ipetkov/crane#271 (comment)

@rvolosatovs
Copy link
Member Author

Alternative, and probably cleaner solution could be adopting something like https://github.com/rvolosatovs/depit once bytecodealliance/wit-deps#9 is implemented, such that the host crate could be self-contained while still benefiting from importing from the shared WIT definitions from the root of the repo

@rvolosatovs
Copy link
Member Author

Alternative solution in #136.

Symlinks AFAIK can be tricky on Windows, so #136 should be a better option

@sunfishcode
Copy link
Member

Yeah, I agree that symlinks can be tricky here. Fortunately #136 sounds like a good option.

@rvolosatovs
Copy link
Member Author

Closing in favor of #136

@rvolosatovs rvolosatovs deleted the fix/link-wit branch April 12, 2023 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasi subcrate is incompatible with cargo vendor
2 participants