Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(infinite-scroll): use proper equality check #24767

Merged
merged 2 commits into from
Feb 22, 2022
Merged

docs(infinite-scroll): use proper equality check #24767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
536c5ab
fix(readme.md): double equality
matzar Feb 10, 2022
00aebe7
docs(infinite-scroll, usage): changed double equity to tripple equity…
matzar Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions core/src/components/infinite-scroll/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class InfiniteScrollExample {

// App logic to determine if all data is loaded
// and disable the infinite scroll
if (data.length == 1000) {
if (data.length === 1000) {
event.target.disabled = true;
}
}, 500);
Expand Down Expand Up @@ -111,7 +111,7 @@ infiniteScroll.addEventListener('ionInfinite', function(event) {

// App logic to determine if all data is loaded
// and disable the infinite scroll
if (data.length == 1000) {
if (data.length === 1000) {
event.target.disabled = true;
}
}, 500);
Expand Down Expand Up @@ -164,7 +164,7 @@ const InfiniteScrollExample: React.FC = () => {
pushData();
console.log('Loaded data');
ev.target.complete();
if (data.length == 1000) {
if (data.length === 1000) {
setInfiniteDisabled(true);
}
}, 500);
Expand Down Expand Up @@ -263,7 +263,7 @@ export class InfiniteScrollExample {

// App logic to determine if all data is loaded
// and disable the infinite scroll
if (this.data.length == 1000) {
if (this.data.length === 1000) {
ev.target.disabled = true;
}
}, 500);
Expand Down Expand Up @@ -380,7 +380,7 @@ export default defineComponent({

// App logic to determine if all data is loaded
// and disable the infinite scroll
if (items.value.length == 1000) {
if (items.value.length === 1000) {
ev.target.disabled = true;
}
}, 500);
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/infinite-scroll/usage/angular.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class InfiniteScrollExample {

// App logic to determine if all data is loaded
// and disable the infinite scroll
if (data.length == 1000) {
if (data.length === 1000) {
event.target.disabled = true;
}
}, 500);
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/infinite-scroll/usage/javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ infiniteScroll.addEventListener('ionInfinite', function(event) {

// App logic to determine if all data is loaded
// and disable the infinite scroll
if (data.length == 1000) {
if (data.length === 1000) {
event.target.disabled = true;
}
}, 500);
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/infinite-scroll/usage/react.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const InfiniteScrollExample: React.FC = () => {
pushData();
console.log('Loaded data');
ev.target.complete();
if (data.length == 1000) {
if (data.length === 1000) {
setInfiniteDisabled(true);
}
}, 500);
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/infinite-scroll/usage/stencil.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class InfiniteScrollExample {

// App logic to determine if all data is loaded
// and disable the infinite scroll
if (this.data.length == 1000) {
if (this.data.length === 1000) {
ev.target.disabled = true;
}
}, 500);
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/infinite-scroll/usage/vue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default defineComponent({

// App logic to determine if all data is loaded
// and disable the infinite scroll
if (items.value.length == 1000) {
if (items.value.length === 1000) {
ev.target.disabled = true;
}
}, 500);
Expand Down