-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(infinite-scroll): use proper equality check #24767
Conversation
Expected '===' instead saw '=='.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 5 occurrences of this issue in this file. Can you please update all of them at once? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checked everything - 5 occurences of double-equals have been replaced with tripple-equals.
Thanks for the PR! The readme file you've updated is mostly auto-generated (everything below the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This LGTM once tests pass and Sean has a chance to take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the package-lock changes?
Now I've commited only |
Changed '==' to '===' in infinite-scroll readme.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Updated documentation so people don't get scared when seeing '==' equality.
Issue Number: #
What is the new behavior?
Changed '==' to '===' in infinite-scroll Usage code example.
Does this introduce a breaking change?
Other information