fix(item-option): add styling for slots other than icon-only #17711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was not working before this at all, also removes the e2e test from item/sliding in favor of all of them being under item-sliding, and adds JS usage TODO: - add e2e test with screenshots of this - verify / clean up CSS design - add other usage examples
liamdebeasi
approved these changes
Mar 11, 2019
jthoms1
approved these changes
Mar 11, 2019
moves open and close functions to utils
|
Good to merge once the build passes 👍 |
kiku-jw
pushed a commit
to kiku-jw/ionic
that referenced
this pull request
May 16, 2019
…eam#17711) styles the item option properly when icons are slotted. This was not working before at all for `top` and `bottom` slots. - removes the e2e test from item/sliding in favor of all of them being under item-sliding - adds more usage examples for all frameworks - updates the styling for an anchor option so that it displays properly - updates the standalone e2e test to take screenshots of the start icon, top icon, and anchor options - updates the interactive e2e test to work locally - cleaned up the CSS for start/end icons - verified the styles for ben approval 💪 closes ionic-team#17737 fixes ionic-team#17402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styles the item option properly when icons are slotted. This was not working before at all for
topandbottomslots.Also:
closes #17737 fixes #17402