-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ionic v4] (ion-item-option + routerlink) > ion-icon => icon displays too low #17402
Comments
The problem comes from the ion-item-option > #shadow-root > a class="button-native" I tried to add this sample of code in global.css .button-native {
padding: 0;
} But the bug isn't fixed. Any idea how to fix it ? |
Thank you for the issue! I was able to reproduce this in the conference app, it looks like the problem is the rendering of an
The problem is it isn't easy to apply a workaround on this, but I will add this fix in as part of this PR: #17711 |
styles the item option properly when icons are slotted. This was not working before at all for `top` and `bottom` slots. - removes the e2e test from item/sliding in favor of all of them being under item-sliding - adds more usage examples for all frameworks - updates the styling for an anchor option so that it displays properly - updates the standalone e2e test to take screenshots of the start icon, top icon, and anchor options - updates the interactive e2e test to work locally - cleaned up the CSS for start/end icons - verified the styles for ben approval 💪 closes #17737 fixes #17402
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
…eam#17711) styles the item option properly when icons are slotted. This was not working before at all for `top` and `bottom` slots. - removes the e2e test from item/sliding in favor of all of them being under item-sliding - adds more usage examples for all frameworks - updates the styling for an anchor option so that it displays properly - updates the standalone e2e test to take screenshots of the start icon, top icon, and anchor options - updates the interactive e2e test to work locally - cleaned up the CSS for start/end icons - verified the styles for ben approval 💪 closes ionic-team#17737 fixes ionic-team#17402
Ionic info:
Bug Report
Ionic version:
[x] 4.8.0
Current behavior:
The icon misaligns and is displayed too low when an ion-item-option is used with a routerLink
Expected behavior:
Aligned icons
Steps to reproduce:
1 - Run a sample of code using the related code
2 - Slide the item using the routerLink
Related code:
Working solution
Remove "[routerLink]="..." routerDirection="..." corrects the bug
The text was updated successfully, but these errors were encountered: