Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed link for Travis CI badge #337

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

YanniPapandreou
Copy link
Contributor

@YanniPapandreou YanniPapandreou commented Jan 14, 2022

Badge link for Travis CI was pointing to "https://travis-ci.com/{{{USER}}}/{{{PKG}}}.jl" which does not seem to be the correct link. Changed this to "https://app.travis-ci.com/{{{USER}}}/{{{PKG}}}.jl" which seems to work. :)

close #338

Badge link for Travis CI was pointing to "https://travis-ci.com/{{{USER}}}/{{{PKG}}}.jl" which does not seem to be the correct link. Changed this to "https://app.travis-ci.com/{{{USER}}}/{{{PKG}}}.jl" which seems to work. :)
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #337 (0c01dc9) into master (015dfc4) will decrease coverage by 22.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #337       +/-   ##
===========================================
- Coverage   94.62%   71.96%   -22.66%     
===========================================
  Files          20       20               
  Lines         632      528      -104     
===========================================
- Hits          598      380      -218     
- Misses         34      148      +114     
Impacted Files Coverage Δ
src/plugins/ci.jl 15.49% <ø> (-81.98%) ⬇️
src/plugins/develop.jl 0.00% <0.00%> (-100.00%) ⬇️
src/plugins/register.jl 0.00% <0.00%> (-100.00%) ⬇️
src/plugins/coverage.jl 0.00% <0.00%> (-90.91%) ⬇️
src/plugins/citation.jl 0.00% <0.00%> (-80.00%) ⬇️
src/plugins/compat_helper.jl 50.00% <0.00%> (-50.00%) ⬇️
src/plugins/badges.jl 57.14% <0.00%> (-42.86%) ⬇️
src/plugins/tagbot.jl 62.50% <0.00%> (-37.50%) ⬇️
src/plugins/src_dir.jl 75.00% <0.00%> (-25.00%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015dfc4...0c01dc9. Read the comment docs.

@nickrobinson251
Copy link
Collaborator

nickrobinson251 commented Jan 14, 2022

Thanks! Can you find any info (eg. a blog post by TravisCI) that indicates that this changed and this update URL is the right one?

@nickrobinson251
Copy link
Collaborator

nickrobinson251 commented Jan 14, 2022

For tests to pass, you will need to update the reference tests to have the updated URL. You can do this by running in tests locally using Julia 1.7, and you should see the reference tests fail and be given the option to have them automatically updated for you (https://invenia.github.io/PkgTemplates.jl/dev/developer/#Updating-Reference-Tests-and-Fixtures-1) -- let me know if you run into any issues with that!

@YanniPapandreou
Copy link
Contributor Author

Thanks! Can you find any info (eg. a blog post by TravisCI) that indicates that this changed and this update URL is the right one?

When I used the original link it took me to an "error 404 page not found" even though on my Travis account I could find the repo being checked. The link was the proposed change. Not sure however if this might have to do with my OS?

@nickrobinson251
Copy link
Collaborator

yeah i'm still happy enough to make this change if it's what you find actually works, even absent any official info from Travis; it'd just be nice to know when/why this changed if possible (presuming this used to work, which i'm fairly sure it did)

@YanniPapandreou
Copy link
Contributor Author

For tests to pass, you will need to update the reference tests to have the updated URL. You can do this by running in tests locally using Julia 1.7, and you should see the reference tests fail and be given the option to have them automatically updated for you (https://invenia.github.io/PkgTemplates.jl/dev/developer/#Updating-Reference-Tests-and-Fixtures-1) -- let me know if you run into any issues with that!

So I think the same test fails even on the free package without me making my change. However, I have tried starting my REPL, then accessing the Pkg REPL doing dev PkgTemplates making my changes and then finally in the Pkg REPL doing test PkgTemplates. The tests run and the reference test fails like you say, however, I do not seem to have an option to automatically change the URL. Is there another why I should be running the tests? I am not understanding the link you sent sorry, I am very new to all of this.

@nickrobinson251 nickrobinson251 self-assigned this Jan 19, 2022
@nickrobinson251 nickrobinson251 self-requested a review January 19, 2022 15:12
@nickrobinson251 nickrobinson251 removed their assignment Jan 19, 2022
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7b5a51) 92.91% compared to head (cdeb39a) 92.94%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   92.91%   92.94%   +0.02%     
==========================================
  Files          23       24       +1     
  Lines         734      737       +3     
==========================================
+ Hits          682      685       +3     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 8b012e1 into JuliaCI:master Dec 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing link for Travis CI badge
3 participants