Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing link for Travis CI badge #338

Closed
YanniPapandreou opened this issue Jan 14, 2022 · 1 comment · Fixed by #337
Closed

Fixing link for Travis CI badge #338

YanniPapandreou opened this issue Jan 14, 2022 · 1 comment · Fixed by #337
Labels

Comments

@YanniPapandreou
Copy link
Contributor

Hi,

I was following a tutorial online for using PkgTemplates to create a Julia package. I used the following template:

using PkgTemplates

t = Template(; 
    user="YanniPapandreou",
    authors=["Yanni Papandreou"],
    plugins=[
        License(; name="MIT"),
        TravisCI(),
        Codecov(),
        Coveralls(),
        AppVeyor(),
    ],
)

t("MyExample")

The generated README.md file generated a Travis CI badge whose link did not work. This linked to https://travis-ci.com/YanniPapandreou/MyExample.jl instead of the correct link https://app.travis-ci.com/YanniPapandreou/MyExample.jl. I have changed the CI.jl code to use the correct link, the relevant changes are detailed below:

  • Original:
badges(::TravisCI) = Badge(
    "Build Status",
    "https://travis-ci.com/{{{USER}}}/{{{PKG}}}.jl.svg?branch={{{BRANCH}}}",
    "https://travis-ci.com/{{{USER}}}/{{{PKG}}}.jl",
)
  • Changed:
badges(::TravisCI) = Badge(
    "Build Status",
    "https://app.travis-ci.com/{{{USER}}}/{{{PKG}}}.jl.svg?branch={{{BRANCH}}}",
    "https://app.travis-ci.com/{{{USER}}}/{{{PKG}}}.jl",
)

I submitted but then closed a pull request as I read that it is better to first submit an issue; I am new to contributing to open source. If this is something that should be changed I am happy to reopen the pull request. Thanks :)

@nickrobinson251
Copy link
Collaborator

nickrobinson251 commented Jan 14, 2022

Welcome, and thanks for the issue and PR!

I re-opened the PR and left a comment :)

BTW, if don't have a particular reason to use Travis CI for your package I would recommend GithubActions for CI instead 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants