-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed link for Travis CI badge #337
Conversation
Badge link for Travis CI was pointing to "https://travis-ci.com/{{{USER}}}/{{{PKG}}}.jl" which does not seem to be the correct link. Changed this to "https://app.travis-ci.com/{{{USER}}}/{{{PKG}}}.jl" which seems to work. :)
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
===========================================
- Coverage 94.62% 71.96% -22.66%
===========================================
Files 20 20
Lines 632 528 -104
===========================================
- Hits 598 380 -218
- Misses 34 148 +114
Continue to review full report at Codecov.
|
Thanks! Can you find any info (eg. a blog post by TravisCI) that indicates that this changed and this update URL is the right one? |
For tests to pass, you will need to update the reference tests to have the updated URL. You can do this by running in tests locally using Julia 1.7, and you should see the reference tests fail and be given the option to have them automatically updated for you (https://invenia.github.io/PkgTemplates.jl/dev/developer/#Updating-Reference-Tests-and-Fixtures-1) -- let me know if you run into any issues with that! |
When I used the original link it took me to an "error 404 page not found" even though on my Travis account I could find the repo being checked. The link was the proposed change. Not sure however if this might have to do with my OS? |
yeah i'm still happy enough to make this change if it's what you find actually works, even absent any official info from Travis; it'd just be nice to know when/why this changed if possible (presuming this used to work, which i'm fairly sure it did) |
So I think the same test fails even on the free package without me making my change. However, I have tried starting my REPL, then accessing the Pkg REPL doing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 92.91% 92.94% +0.02%
==========================================
Files 23 24 +1
Lines 734 737 +3
==========================================
+ Hits 682 685 +3
Misses 52 52 ☔ View full report in Codecov by Sentry. |
Badge link for Travis CI was pointing to "https://travis-ci.com/{{{USER}}}/{{{PKG}}}.jl" which does not seem to be the correct link. Changed this to "https://app.travis-ci.com/{{{USER}}}/{{{PKG}}}.jl" which seems to work. :)
close #338