Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change jobs from Que to ActiveJob #1717

Closed
wants to merge 4 commits into from
Closed

Change jobs from Que to ActiveJob #1717

wants to merge 4 commits into from

Conversation

yulgolem
Copy link
Contributor

@yulgolem yulgolem commented Oct 19, 2020 •
edited
Loading

Related to #645

@yulgolem yulgolem force-pushed the 645-gracefully-drop-que-email-jobs branch 12 times, most recently from a13b92f to ae8c5ec Compare October 21, 2020 12:12
@yulgolem
Copy link
Contributor Author

yulgolem commented Oct 21, 2020 •
edited
Loading

Not sure if it will be possible to cancel domain deleting job, this needs to be checked.

@yulgolem yulgolem force-pushed the 645-gracefully-drop-que-email-jobs branch 8 times, most recently from 2228fdb to 27e585e Compare October 23, 2020 09:35
@yulgolem yulgolem marked this pull request as ready for review October 23, 2020 10:13
@yulgolem yulgolem changed the title Move RegistrantChangeNoticeEmailJob from Que to ActiveJob Change jobs from Que to ActiveJob Oct 23, 2020
@yulgolem yulgolem mentioned this pull request Oct 27, 2020
Closed
@yulgolem yulgolem force-pushed the 645-gracefully-drop-que-email-jobs branch from 27e585e to 1e4531e Compare October 27, 2020 10:07
@yulgolem yulgolem mentioned this pull request Oct 28, 2020
Closed
@yulgolem
Copy link
Contributor Author

@vohmar assuming it will be a pain in the neck testing this whole bunch of code, I might as well move jobs from Que to Active Job as per #1198 , one job at a time/PR.

@yulgolem yulgolem force-pushed the 645-gracefully-drop-que-email-jobs branch 3 times, most recently from 586239d to c709603 Compare February 25, 2021 09:43
@yulgolem yulgolem assigned OlegPhenomenon and unassigned vohmar Feb 25, 2021
@yulgolem yulgolem force-pushed the 645-gracefully-drop-que-email-jobs branch from c709603 to 23f0a80 Compare February 25, 2021 09:52
@yulgolem yulgolem assigned vohmar and unassigned OlegPhenomenon Feb 25, 2021
@yulgolem yulgolem force-pushed the 645-gracefully-drop-que-email-jobs branch 3 times, most recently from 2263012 to 1b78b9e Compare March 2, 2021 10:54
@yulgolem yulgolem force-pushed the 645-gracefully-drop-que-email-jobs branch from 1b78b9e to 3b0509b Compare March 2, 2021 11:01
@yulgolem yulgolem force-pushed the 645-gracefully-drop-que-email-jobs branch 7 times, most recently from 5db2c14 to bbc5690 Compare March 2, 2021 13:09
@yulgolem yulgolem force-pushed the 645-gracefully-drop-que-email-jobs branch from bbc5690 to 8a62f33 Compare March 2, 2021 13:13
@yulgolem yulgolem marked this pull request as draft March 3, 2021 08:21
@yulgolem yulgolem closed this Apr 12, 2021
@vohmar vohmar deleted the 645-gracefully-drop-que-email-jobs branch June 8, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlerikounapuu karlerikounapuu karlerikounapuu approved these changes

Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yulgolem @karlerikounapuu @vohmar @OlegPhenomenon