Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify/refactor domain delete procedures (auction on/off, delete/force delete) #1198

Closed
artur-intech opened this issue May 10, 2019 · 3 comments
Assignees
Labels
refactor Refactoring of existing feature

Comments

@artur-intech
Copy link
Contributor

No description provided.

@yulgolem
Copy link
Contributor

yulgolem commented Nov 9, 2020

So in order to incapsulate domain managing (at least deletion) procedures we are to use Interactor design pattern (https://mkdev.me/en/posts/a-couple-of-words-about-interactors-in-rails).

The main point of this refactoring is to unify domain behaviour. For example, we are using DomainDeleteConfirmJob for domain deletion, but methods of domain instance (described in concerns/domain/force_delete) for setting ForceDelete status on a domain.

By introducing interactors we'll gain single incapsulated source of changes related to task, so we should put there all the notifications etc.

For implementation we'll need to do the following refactoring:

@yulgolem
Copy link
Contributor

yulgolem commented Jan 5, 2021

Everything is done, the task might be closed now.

@yulgolem yulgolem assigned vohmar and unassigned yulgolem Jan 5, 2021
@vohmar
Copy link
Contributor

vohmar commented Jan 8, 2021

done, thank you!

@vohmar vohmar closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

No branches or pull requests

3 participants