Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lookup-refs #303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove lookup-refs #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,24 +34,6 @@ jobs:
TLG_CATALOG_PKG_BUILD_RENDER=TRUE
concurrency-group: development
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/random.cdisc.data
insightsengineering/formatters
insightsengineering/rlistings
insightsengineering/rtables
insightsengineering/tern
insightsengineering/tern.mmrm
insightsengineering/tern.rbmi
insightsengineering/teal.data
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.slice
insightsengineering/teal.transform
insightsengineering/teal.widgets
insightsengineering/teal
insightsengineering/teal.modules.general
insightsengineering/teal.modules.clinical
skip-desc-dev: true
repository-list: "r-universe-dev=https://pharmaverse.r-universe.dev/, PPM=PPM@latest"
cache-version: "dev"
Expand Down
4 changes: 4 additions & 0 deletions package/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ Suggests:
vdiffr,
webshot2,
withr
Remotes:
insightsengineering/teal.modules.clinical,
insightsengineering/teal,
insightsengineering/tern
Comment on lines +50 to +53
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description file doesn't specify the (dev) version required for teal.modules.clinical, teal or tern. I assume that teal and TMC are still on devel but tern was recently published (2025-01-17) and I'm not totally sure if it needs the devel version or not. Could you add it? This might help users that attempt to use this catalog on older versions of packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llrs-roche I am not sure what versions of dependencies should be added in here neither.
tmc and teal are up to be released, so probably we should stick to the dev versions.
tern is published on CRAN but there were already 3 vbumps in the dev version of this package.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then better to make the dependency explicit, that do not state it and hope for the best.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think released versions of all the dependcies could be added.
What are your thoughts @donyunardi @pawelru @shajoezhu @vedhav

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Marcin. This one is a tricky one - watch out!

First of all - we are running both "all-stable" and "all-devel" installations. It is assumed that this is controlled mostly by R pkg repos: for stable we are using r-universe/ie and for devel we are using r-universe/pharmaverse. My understanding is that if you put something to Remotes it's going to be used in both which is not what we want (or we can skip-remotes in the stable somehow?)

(I putted refs to r-cmd-check pipelines but the same logic exists for pkgdown)

On the other hand - this repo will be archived rather sooner than later and we will move on to have internal catalog so please don't overdo this if you know what I mean.

Config/testthat/edition: 3
Encoding: UTF-8
Language: en-US
Expand Down
Loading