Remove lookup-refs #303
Remove lookup-refs #303
Conversation
Unit Tests Summary340 tests 248 ✅ 1m 1s ⏱️ For more details on these failures, see this check. Results for commit d73bb45. ♻️ This comment has been updated with latest results. |
| Remotes: | ||
| insightsengineering/teal.modules.clinical, | ||
| insightsengineering/teal, | ||
| insightsengineering/tern |
There was a problem hiding this comment.
The description file doesn't specify the (dev) version required for teal.modules.clinical, teal or tern. I assume that teal and TMC are still on devel but tern was recently published (2025-01-17) and I'm not totally sure if it needs the devel version or not. Could you add it? This might help users that attempt to use this catalog on older versions of packages.
There was a problem hiding this comment.
@llrs-roche I am not sure what versions of dependencies should be added in here neither.
tmc and teal are up to be released, so probably we should stick to the dev versions.
tern is published on CRAN but there were already 3 vbumps in the dev version of this package.
There was a problem hiding this comment.
Then better to make the dependency explicit, that do not state it and hope for the best.
There was a problem hiding this comment.
I think released versions of all the dependcies could be added.
What are your thoughts @donyunardi @pawelru @shajoezhu @vedhav
There was a problem hiding this comment.
Hey Marcin. This one is a tricky one - watch out!
First of all - we are running both "all-stable" and "all-devel" installations. It is assumed that this is controlled mostly by R pkg repos: for stable we are using r-universe/ie and for devel we are using r-universe/pharmaverse. My understanding is that if you put something to Remotes it's going to be used in both which is not what we want (or we can skip-remotes in the stable somehow?)
(I putted refs to r-cmd-check pipelines but the same logic exists for pkgdown)
On the other hand - this repo will be archived rather sooner than later and we will move on to have internal catalog so please don't overdo this if you know what I mean.
Part of https://github.com/insightsengineering/coredev-tasks/issues/609
From now on, we will provide development dependencies in
format, so it's explicitly visible in the DESCRIPTION file and can be handled by
pak::install,renv::installandremotes::install.With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.