Teal refactor #768
Merged
Teal refactor #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update examples and example_module to use data * update vignette to use quosures * reprorting vignette updated * reporter previewer module * add parent dataset to data even if not specified in module$filters * deprecate show r code * add .datasets_to_data tests Co-authored-by: Dawid Kałędkowski <[email protected]>
8 tasks
|
Code Coverage SummaryResults for commit: 79542cb Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Signed-off-by: Nikolas Burkoff <[email protected]>
nikolas-burkoff
commented
Oct 28, 2022
nikolas-burkoff
commented
Nov 2, 2022
| card$append_text("Show R Code", "header3") | ||
| card$append_text(paste(teal.code::chunks_get_rcode(simple_chunks), collapse = "\n"), "verbatim") | ||
| card$append_text(paste(teal.code::get_code(table_q()), collapse = "\n"), "verbatim") |
There was a problem hiding this comment.
should this be append src @Polkas
nikolas-burkoff
commented
Nov 2, 2022
added 5 commits
November 2, 2022 16:55
Signed-off-by: Nikolas Burkoff <[email protected]>
nikolas-burkoff
commented
Nov 3, 2022
Signed-off-by: Nikolas Burkoff <[email protected]>
nikolas-burkoff
commented
Nov 3, 2022
Signed-off-by: Nikolas Burkoff <[email protected]>
nikolas-burkoff
commented
Nov 3, 2022
donyunardi
reviewed
Nov 3, 2022
R/tdata.R
Outdated
| @@ -0,0 +1,171 @@ | |||
| #' Create a new `tdata` object which contains | |||
There was a problem hiding this comment.
The title of the manual for tdata is Create a new tdata object which contains.
It felt incorrect.
Along with the description, maybe we can do something like this?
#' Create a `tdata` Object
#'
#' Create a new object called `tdata` which contains `data`, a `reactive` list of data.frames
#' (or `MultiAssayExperiment`), with attributes:
#' \itemize{
#' \item{`code` (`reactive`) containing code used to generate the data}
#' \item{join_keys (`JoinKeys`) containing the relationships between the data}
#' \item{metadata (`named list`) containing any metadata associated with the data frames}
#' }
It looks better in the manual page:
donyunardi
reviewed
Nov 3, 2022
Co-authored-by: Dony Unardi <[email protected]> Signed-off-by: Nikolas Burkoff <[email protected]>
gogonzo
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #731