Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapper for get_code.tdata #739

Merged
merged 11 commits into from
Oct 27, 2022
Merged

wrapper for get_code.tdata #739

merged 11 commits into from
Oct 27, 2022

Conversation

mhallal1
Copy link
Collaborator

@mhallal1 mhallal1 added the core label Sep 28, 2022
@nikolas-burkoff nikolas-burkoff changed the base branch from main to teal_refactor@main September 28, 2022 11:43
nikolas-burkoff
nikolas-burkoff approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment then this can be merged in - I've change branch to teal_refactor@main

I guess we can open PRs in the modules to use this and also make changes for warnings

Nikolas Burkoff and others added 2 commits September 28, 2022 12:48
nikolas-burkoff
nikolas-burkoff approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a couple of tests too

@mhallal1 mhallal1 mentioned this pull request Sep 28, 2022
Merged
@mhallal1
Copy link
Collaborator Author

mhallal1 commented Sep 29, 2022 •
edited
Loading

@nikolas-burkoff tests added for this functionality.

@mhallal1 mhallal1 mentioned this pull request Sep 29, 2022
Merged
@nikolas-burkoff nikolas-burkoff mentioned this pull request Sep 29, 2022
Closed
8 tasks
@donyunardi donyunardi mentioned this pull request Oct 7, 2022
Closed
21 tasks
@gogonzo gogonzo self-assigned this Oct 27, 2022
@nikolas-burkoff nikolas-burkoff merged commit 729ba4f into teal_refactor@main Oct 27, 2022
@nikolas-burkoff nikolas-burkoff deleted the 63_warnings@teal_refactor@main branch October 27, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gogonzo gogonzo gogonzo approved these changes

@nikolas-burkoff nikolas-burkoff nikolas-burkoff approved these changes

Assignees

@gogonzo gogonzo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhallal1 @gogonzo @nikolas-burkoff @BLAZEWIM